From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0AWQ-0000Sw-2u
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:56:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0AWK-0000RR-Uv
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:56:48 -0400
Received: from [199.232.76.173] (port=35634 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0AWK-0000RO-O9
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:56:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25429)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1N0AWK-0002YE-88
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 04:56:44 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9K8uhAC006238
	for <qemu-devel@nongnu.org>; Tue, 20 Oct 2009 04:56:43 -0400
Message-ID: <4ADD7B48.2030704@redhat.com>
Date: Tue, 20 Oct 2009 10:56:40 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support
	for	multiple ports for generic guest-host communication
References: <1256022825-16180-1-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1256022825-16180-1-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

> This patch series fixes a few problems since the last send, mainly in
> the save/restore code and a few bugs shown by the automated test suite
> (located in a separate git repo, link below).

A bit hard to review in this form, especially the virtio-console.c 
changes, because you put everything upside down in that file.  Hard to 
do better though given the massive code reorganization ...

So I applied the bits and looked at the resulting tree instead.  Looks 
good overall, just a few minor nits, check the replies to the individual 
patches.  I think we are ready to go as soon as the linux kernel side is 
on the way to mainline.

cheers,
   Gerd