From: Ben Dooks <ben@simtec.co.uk>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, Simtec Linux Team <linux@simtec.co.uk>
Subject: Re: NAND: Add flags to the probe calls to control scan behaviour
Date: Tue, 20 Oct 2009 14:11:52 +0100 [thread overview]
Message-ID: <4ADDB718.60002@simtec.co.uk> (raw)
In-Reply-To: <1256040395.29856.228.camel@localhost>
Artem Bityutskiy wrote:
> On Mon, 2009-10-19 at 11:36 +0100, Ben Dooks wrote:
>> I'd rather it be silent if it cannot find a device, as a number of our boards
>> have slots where NAND devices may be fitted by the customer and as such all
>> possibilities are registered with the NAND driver.
>>
>>> Could you please elaborate why more why is this needed a bit more? What
>>> is the driver?
>> Because customers get scared when errors with '!!!' turn up.
>
>>> Why not to just remove that print at all?
>> Possible, but what about the case where there is a legitimate problem with
>> the device that is supposed to be there.
>
> I would go for this instead. I think the drivers can print an error
> message themselves.
I was trying to avoid touching the 40+ drivers which use this
code. This would also be a bit of a code bloat as we would have
some interesting checks for the precise error code (was the failure
no-chip, no memory, some other problem?)
> Or can this be done using the chip->options ?
I will look into this.
--
Ben Dooks, Software Engineer, Simtec Electronics
http://www.simtec.co.uk/
prev parent reply other threads:[~2009-10-20 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 9:00 NAND: Add flags to the probe calls to control scan behaviour Ben Dooks
2009-10-14 15:37 ` Artem Bityutskiy
2009-10-19 10:36 ` Ben Dooks
2009-10-20 12:06 ` Artem Bityutskiy
2009-10-20 13:11 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADDB718.60002@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.