From: Avi Kivity <avi@redhat.com>
To: Chris Lalancette <clalance@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] Fix up vmx_set_segment for booting older guests.
Date: Tue, 20 Oct 2009 22:20:26 +0900 [thread overview]
Message-ID: <4ADDB91A.9040502@redhat.com> (raw)
In-Reply-To: <4ADD8A98.4010706@redhat.com>
On 10/20/2009 07:02 PM, Chris Lalancette wrote:
> get_desc_base() sign-extends because of some complicated u8 to unsigned rules
> that I'm not completely sure of. The below patch fixes my original issue, but
> I'm not at all sure that this is the right thing to do. I could also change
> get_desc_base() itself to do the casting, which should do the right thing for
> all callers, but I'm not sure if that's what all callers want. Anybody else
> have an opinion?
>
get_desc_base() is broken and should be fixed. No caller could possibly
want this sign extension (64-bit segment bases are only possible using
MSR_FS_BASE/MSR_GS_BASE/MSR_KERNEL_GS_BASE).
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2009-10-20 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 7:50 [PATCH] Fix up vmx_set_segment for booting older guests Chris Lalancette
2009-10-20 8:10 ` Avi Kivity
2009-10-20 10:02 ` Chris Lalancette
2009-10-20 13:20 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADDB91A.9040502@redhat.com \
--to=avi@redhat.com \
--cc=clalance@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.