From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0FIB-0007W3-CJ
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 10:02:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0FI5-0007Vb-6O
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 10:02:25 -0400
Received: from [199.232.76.173] (port=57328 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0FI5-0007VY-04
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 10:02:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56667)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1N0FI4-0001nb-By
	for qemu-devel@nongnu.org; Tue, 20 Oct 2009 10:02:20 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9KE2JQA012625
	for <qemu-devel@nongnu.org>; Tue, 20 Oct 2009 10:02:19 -0400
Message-ID: <4ADDC2E8.5040601@redhat.com>
Date: Tue, 20 Oct 2009 16:02:16 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a
	new	virtserialport device for generic serial port support
References: <1256022825-16180-1-git-send-email-amit.shah@redhat.com>
	<1256022825-16180-2-git-send-email-amit.shah@redhat.com>
	<1256022825-16180-3-git-send-email-amit.shah@redhat.com>
	<1256022825-16180-4-git-send-email-amit.shah@redhat.com>
	<4ADD7A12.1040305@redhat.com>
	<20091020094806.GA4405@amit-x200.redhat.com>
In-Reply-To: <20091020094806.GA4405@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/20/09 11:48, Amit Shah wrote:
> On (Tue) Oct 20 2009 [10:51:30], Gerd Hoffmann wrote:
>>> @@ -107,3 +107,41 @@ static void virtcon_register(void)
>>>        virtio_serial_port_qdev_register(&virtcon_info);
>>>    }
>>>    device_init(virtcon_register)
>>
>>> +static VirtIOSerialPortInfo virtserial_port_info = {
>>> +    .qdev.name     = "virtserialport",
>>> +    .qdev.size     = sizeof(VirtConsole),
>>> +    .init          = virtserial_port_initfn,
>>> +    .have_data     = flush_buf,
>>> +    .qdev.props = (Property[]) {
>>> +        DEFINE_PROP_CHR("chardev", VirtConsole, chr),
>>> +        DEFINE_PROP_STRING("name", VirtIOSerialPort, name),
>>
>> likewise: DEFINE_PROP_STRING("name", VirtConsole, port.name),
>
> The 'name' field is common to all ports, so it makes sense to put it in
> the VirtIOSerialPort struct. (Internal users can pre-define it to their
> liking, eg, org.qemu.vnc)

Sure.  I don't want to move it out there.  But the driver state struct 
is 'VirtConsole' so all properties should use that.  Note that the field 
changed too: from "name" to "port.name", so everything keeps working ;)

cheers,
   Gerd