All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: "J. Bruce Fields" <bfields@citi.umich.edu>,
	Benny Halevy <bhalevy@panasas.com>,
	pNFS Mailing List <pnfs@linux-nfs.org>,
	NFS list <linux-nfs@vger.kernel.org>
Subject: [PATCH version 2] nfsd: Remove nfsfh.h dependency on sunrpc
Date: Tue, 20 Oct 2009 20:39:46 +0200	[thread overview]
Message-ID: <4ADE03F2.5020305@panasas.com> (raw)
In-Reply-To: <4ADDCA9A.3060004@panasas.com>


linux/nfsd/nfsfh.h defines some low level types which
are needed by exportfs and though by filesystems.

In the file, fh_lock() uses the sunrpc dprint facility which
might cause a dependency of exportfs (and filesystems) on
sunrpc which is unwanted.

Remove the debug-print from fh_lock() and avoid this dependency.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
 fs/nfsd/pnfsd_lexp.c       |    3 ++-
 fs/nfsd/spnfs_com.c        |    3 ++-
 include/linux/nfsd/nfsfh.h |    4 ----
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/nfsd/pnfsd_lexp.c b/fs/nfsd/pnfsd_lexp.c
index 23789d6..2bcb6b5 100644
--- a/fs/nfsd/pnfsd_lexp.c
+++ b/fs/nfsd/pnfsd_lexp.c
@@ -27,7 +27,8 @@
 #include <linux/nfsd/state.h>
 #include <linux/nfsd/pnfsd.h>
 #include <linux/nfsd/nfs4layoutxdr.h>
-
+#include <linux/nfsd/debug.h>
+ 
 #define NFSDDBG_FACILITY NFSDDBG_PNFS
 
 struct sockaddr pnfsd_lexp_addr;
diff --git a/fs/nfsd/spnfs_com.c b/fs/nfsd/spnfs_com.c
index f8b7b63..7c7d48d 100644
--- a/fs/nfsd/spnfs_com.c
+++ b/fs/nfsd/spnfs_com.c
@@ -58,7 +58,8 @@
 #include <linux/nfs_fs.h>
 
 #include <linux/nfsd4_spnfs.h>
-
+#include <linux/nfsd/debug.h>
+ 
 #define	NFSDDBG_FACILITY		NFSDDBG_PROC
 
 static ssize_t   spnfs_pipe_upcall(struct file *, struct rpc_pipe_msg *,
diff --git a/include/linux/nfsd/nfsfh.h b/include/linux/nfsd/nfsfh.h
index 94c1aee..b91760c 100644
--- a/include/linux/nfsd/nfsfh.h
+++ b/include/linux/nfsd/nfsfh.h
@@ -20,7 +20,6 @@
 # include <linux/fs.h>
 #endif
 #include <linux/nfsd/const.h>
-#include <linux/nfsd/debug.h>
 
 /*
  * This is the old "dentry style" Linux NFSv2 file handle.
@@ -330,9 +329,6 @@ fh_lock_nested(struct svc_fh *fhp, unsigned int subclass)
 	struct dentry	*dentry = fhp->fh_dentry;
 	struct inode	*inode;
 
-	dfprintk(FILEOP, "nfsd: fh_lock(%s) locked = %d\n",
-			SVCFH_fmt(fhp), fhp->fh_locked);
-
 	BUG_ON(!dentry);
 
 	if (fhp->fh_locked) {
-- 
1.6.2.1



      parent reply	other threads:[~2009-10-20 18:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 14:35 [PATCH] nfsd: Remove nfsfh.h dependency on sunrpc Boaz Harrosh
2009-10-20 15:12 ` Boaz Harrosh
2009-10-20 18:39 ` Boaz Harrosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADE03F2.5020305@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bfields@citi.umich.edu \
    --cc=bhalevy@panasas.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.