From: David Daney <ddaney@caviumnetworks.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
Mikael Pettersson <mikpe@it.uu.se>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic
Date: Tue, 20 Oct 2009 15:44:12 -0700 [thread overview]
Message-ID: <4ADE3D3C.1070608@caviumnetworks.com> (raw)
In-Reply-To: <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com>
Linus Walleij wrote:
> 2009/10/20 David Daney <ddaney@caviumnetworks.com>:
>
>>> Please do not make that functions inline. They are too large and there
>>> is no benefit of inlining them.
>> If that is the case, then perhaps they should not be defined in a header
>> file.
>
> Of course not. There are apropriate places to put them, but as stated
> I think the use as it is today warrants having them inlined.
>
I wasn't trying to imply that they shouldn't be inlined, only that if
you choose (as you did) to define them in a header file, that they
*should* be inline.
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
Mikael Pettersson <mikpe@it.uu.se>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic
Date: Tue, 20 Oct 2009 15:44:12 -0700 [thread overview]
Message-ID: <4ADE3D3C.1070608@caviumnetworks.com> (raw)
Message-ID: <20091020224412.5ldNVnNo4xd6w_AM3MhoG083-UoTSfnZyr0EDpA8LoU@z> (raw)
In-Reply-To: <63386a3d0910201516r71100657y92e3e6c2fab38db9@mail.gmail.com>
Linus Walleij wrote:
> 2009/10/20 David Daney <ddaney@caviumnetworks.com>:
>
>>> Please do not make that functions inline. They are too large and there
>>> is no benefit of inlining them.
>> If that is the case, then perhaps they should not be defined in a header
>> file.
>
> Of course not. There are apropriate places to put them, but as stated
> I think the use as it is today warrants having them inlined.
>
I wasn't trying to imply that they shouldn't be inlined, only that if
you choose (as you did) to define them in a header file, that they
*should* be inline.
David Daney
next prev parent reply other threads:[~2009-10-20 22:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 22:48 [PATCH] Make MIPS dynamic clocksource/clockevent clock code generic Linus Walleij
2009-10-17 22:48 ` Linus Walleij
2009-10-18 22:10 ` Mikael Pettersson
2009-10-18 22:10 ` Mikael Pettersson
2009-10-19 5:17 ` Shane McDonald
2009-10-19 5:17 ` Shane McDonald
2009-10-19 5:17 ` Shane McDonald
2009-10-19 5:22 ` Shane McDonald
2009-10-20 2:25 ` Ralf Baechle
2009-10-20 2:25 ` Ralf Baechle
2009-10-20 3:50 ` Thomas Gleixner
2009-10-20 3:50 ` Thomas Gleixner
2009-10-20 8:19 ` Mikael Pettersson
2009-10-20 8:19 ` Mikael Pettersson
2009-10-20 21:27 ` Linus Walleij
2009-10-20 21:27 ` Linus Walleij
2009-10-20 21:27 ` Linus Walleij
2009-10-20 21:56 ` David Daney
2009-10-20 22:16 ` Linus Walleij
2009-10-20 22:16 ` Linus Walleij
2009-10-20 22:16 ` Linus Walleij
2009-10-20 22:44 ` David Daney [this message]
2009-10-20 22:44 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADE3D3C.1070608@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mikpe@it.uu.se \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.