Re: [PATCH] sata_sil: fix uninitialized variable use when sil_scr_read() fails

[Tejun Heo <tj@kernel.org>]

Yoichi Yuasa wrote:
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> 
> ---
>  drivers/ata/sata_sil.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
> index 3cb69d5..d7fff6b 100644
> --- a/drivers/ata/sata_sil.c
> +++ b/drivers/ata/sata_sil.c
> @@ -439,7 +439,7 @@ static void sil_host_intr(struct ata_port *ap, u32 bmdma2)
>  	u8 status;
>  
>  	if (unlikely(bmdma2 & SIL_DMA_SATA_IRQ)) {
> -		u32 serror;
> +		u32 serror = 0;

The first usage of that is

  sil_scr_read(&ap->link, SCR_ERROR, &serror);

which sets the value.  So, I don't think the patch is necessary.  If
it triggers a compile warning, putting uninitialized_var() macro will
be more appropriate.

Thanks.

-- 
tejun