All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Benny Halevy <bhalevy@gmail.com>,
	"J. Bruce Fields" <bfields@citi.umich.edu>,
	pNFS Mailing List <pnfs@linux-nfs.org>,
	NFS list <linux-nfs@vger.kernel.org>,
	Trond Myklebust <Trond.Myk
Subject: [PATCHSET 0/5] nfsd: Cleanup nfsd/pnfsd headers and code placment
Date: Wed, 21 Oct 2009 10:10:23 +0200	[thread overview]
Message-ID: <4ADEC1EF.8040107@panasas.com> (raw)


In motivation to better organize pnfs code and have minimal impact
on the rest of the nfsd code-base, I've done some cleanups and code
movements. The begging of which was done by Andy in the last round.

The first needed thing was to re-introduce some sense into nfsd
headers. I've taken all include/linux/nfsd/*.h files, one by one,
and included them as first header in a .c file. Then fixed any
missing includes from that header.

Here is current state after this patchset:

// Still BAD
#include <linux/nfsd/const.h> 
	/* NEEDS #include <linux/types.h> in linux/sunrpc/msg_prot.h */
#include <linux/nfsd/export.h> 
	/* NEEDS #include <linux/nfsd/nfsfh.h> */
#include <linux/nfsd/syscall.h> /* Broken because of export.h above */

[Should I fix those too?]

// GOOD or fixed
#include <linux/nfsd/cache.h>
#include <linux/nfsd/debug.h>
#include <linux/nfsd/nfs4layoutxdr.h>
#include <linux/nfsd/nfs4pnfsdlm.h>
#include <linux/nfsd/nfsd4_pnfs.h>
#include <linux/nfsd/nfsd.h>
#include <linux/nfsd/nfsfh.h>
#include <linux/nfsd/pnfsd.h>
#include <linux/nfsd/state.h>
#include <linux/nfsd/stats.h>
#include <linux/nfsd/xdr.h>
#include <linux/nfsd/xdr3.h>
#include <linux/nfsd/xdr4.h>

I then proceeded to re-arrange some pnfs code/definitions into
pnfsd specific files.

And finally all files thouched in this round where include-cleaned

Here are the list of patches:

[PATCH 1/5] sunrpc: Clean never used include files

	This one is for Trond, include-cleaning

[PATCH 2/5] nfsd: Fix independence of a few nfsd related headers
[PATCH 3/5] nfsd: Fix independence of linux/nfsd/ headers

	These two fix nfsd headers independence. As explained above.
	(Should I squash these together)

[PATCH 4/5] SQUASHME pnfsd: Move pnfsd code out of nfs4state.c/h

	Now it is much easier to do this one.

[PATCH 5/5] nfsd: Remove lots of un-needed includes

	And some more include-cleaning

TODO: Some more of above magic done to more nfsd files

Thanks
Boaz

             reply	other threads:[~2009-10-21  8:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21  8:10 Boaz Harrosh [this message]
2009-10-21  8:11 ` [PATCH 1/5] sunrpc: Clean never used include files Boaz Harrosh
2009-10-21 12:54   ` [pnfs] " Boaz Harrosh
2009-10-21 13:26   ` [PATCH version2] " Boaz Harrosh
2009-10-21  8:14 ` [PATCH 2/5] nfsd: Fix independence of a few nfsd related headers Boaz Harrosh
2009-10-22  0:28   ` Trond Myklebust
     [not found]     ` <1256171298.6809.1.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-10-22  8:18       ` Boaz Harrosh
2009-10-22 10:14         ` Benny Halevy
2009-10-22 14:02         ` Trond Myklebust
     [not found]           ` <1256220146.6402.23.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-10-22 15:59             ` Boaz Harrosh
2009-11-04 22:09               ` J. Bruce Fields
2009-11-05  8:48                 ` Boaz Harrosh
2009-11-05 16:33                   ` J. Bruce Fields
2009-11-05 16:41                     ` J. Bruce Fields
2009-11-05 16:59                       ` Trond Myklebust
     [not found]                         ` <1257440343.3114.7.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-11-05 17:03                           ` J. Bruce Fields
2009-11-05 17:06                             ` Trond Myklebust
2009-11-11 14:57                 ` Boaz Harrosh
2009-11-11 17:36                   ` J. Bruce Fields
2009-11-11 17:59                     ` Boaz Harrosh
2009-11-11 18:06                       ` J. Bruce Fields
2009-11-12 10:28   ` [pnfs] " Boaz Harrosh
2009-11-12 10:35     ` Trond Myklebust
     [not found]       ` <1258022133.2973.5.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-11-12 12:48         ` Boaz Harrosh
2009-11-12 13:07           ` Benny Halevy
2009-11-12 13:36           ` Trond Myklebust
     [not found]             ` <1258033010.2968.12.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-11-12 14:45               ` Boaz Harrosh
2009-10-21  8:14 ` [PATCH 3/5] nfsd: Fix independence of linux/nfsd/ headers Boaz Harrosh
2009-10-21  8:15 ` [PATCH 4/5] SQUASHME pnfsd: Move pnfsd code out of nfs4state.c/h Boaz Harrosh
2009-11-03  6:30   ` Benny Halevy
2009-10-21  8:16 ` [PATCH 5/5] nfsd: Remove lots of un-needed includes Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADEC1EF.8040107@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bfields@citi.umich.edu \
    --cc=bhalevy@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pnfs@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.