From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] Update cr3 in PAE mode when guest walk
 succeed but shadow walk fails
Date: Wed, 21 Oct 2009 11:46:00 +0200
Message-ID: <4ADED858.6070201@redhat.com>
References: <de76405a0910160609g5bc1372i5573ba10bb37fbfa@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <de76405a0910160609g5bc1372i5573ba10bb37fbfa@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

> The attached patch solves the problem by calling update_cr3() in that
> path when the guest is in PAE mode, and only ASSERT()ing when the
> guest is not in PAE mode.  The guest will get one spurious page fault,
> but subsequent accesses will succeed.

Hi George,

I suppose this patch is also needed when running 32-on-64.  In that 
case, shouldn't the test be

#if GUEST_PAGING_LEVELS >= 3

rather than "== 3"?

Thanks,

Paolo