From: Paolo Bonzini <pbonzini@redhat.com>
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails
Date: Wed, 21 Oct 2009 11:52:46 +0200 [thread overview]
Message-ID: <4ADED9EE.1050600@redhat.com> (raw)
In-Reply-To: <20091021095006.GI20579@whitby.uk.xensource.com>
On 10/21/2009 11:50 AM, Tim Deegan wrote:
> Hi,
>
> At 10:46 +0100 on 21 Oct (1256121960), Paolo Bonzini wrote:
>> I suppose this patch is also needed when running 32-on-64. In that
>> case, shouldn't the test be
>>
>> #if GUEST_PAGING_LEVELS>= 3
>>
>> rather than "== 3"?
>
> No, '==' is correct. GUEST_PAGING_LEVELS refers to the layout of the
> _guest's_ pagetables, not the shadows. GUEST_PAGING_LEVELS == 4 means
> the guest is using full 64-bit pagetables, which don't have this quirk.
Right, I should have read arch/x86/mm/shadow/Makefile.
Thanks,
Paolo
next prev parent reply other threads:[~2009-10-21 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 13:09 [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails George Dunlap
2009-10-17 13:51 ` John Levon
2009-10-17 14:15 ` Keir Fraser
2009-10-17 14:17 ` John Levon
2009-10-21 9:46 ` Paolo Bonzini
2009-10-21 9:50 ` Tim Deegan
2009-10-21 9:52 ` Paolo Bonzini [this message]
2009-10-21 10:23 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADED9EE.1050600@redhat.com \
--to=pbonzini@redhat.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Tim.Deegan@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.