From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: Re: [PATCH] Update cr3 in PAE mode when guest walk
	succeed but shadow walk fails
Date: Wed, 21 Oct 2009 11:52:46 +0200
Message-ID: <4ADED9EE.1050600@redhat.com>
References: <de76405a0910160609g5bc1372i5573ba10bb37fbfa@mail.gmail.com>
	<4ADED858.6070201@redhat.com>
	<20091021095006.GI20579@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20091021095006.GI20579@whitby.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 10/21/2009 11:50 AM, Tim Deegan wrote:
> Hi,
>
> At 10:46 +0100 on 21 Oct (1256121960), Paolo Bonzini wrote:
>> I suppose this patch is also needed when running 32-on-64.  In that
>> case, shouldn't the test be
>>
>> #if GUEST_PAGING_LEVELS>= 3
>>
>> rather than "== 3"?
>
> No, '==' is correct.  GUEST_PAGING_LEVELS refers to the layout of the
> _guest's_ pagetables, not the shadows.  GUEST_PAGING_LEVELS == 4 means
> the guest is using full 64-bit pagetables, which don't have this quirk.

Right, I should have read arch/x86/mm/shadow/Makefile.

Thanks,

Paolo