From: Johannes Sixt <j.sixt@viscovery.net>
To: kusmabite@gmail.com
Cc: msysgit@googlegroups.com, git@vger.kernel.org,
Marius Storm-Olsen <mstormo@gmail.com>
Subject: Re: [msysGit] [PATCH v4 7/8] mingw: enable OpenSSL
Date: Wed, 21 Oct 2009 14:55:23 +0200 [thread overview]
Message-ID: <4ADF04BB.10302@viscovery.net> (raw)
In-Reply-To: <40aa078e0910210543t2dcc2af6ie16eb0e49895788f@mail.gmail.com>
Erik Faye-Lund schrieb:
> On Wed, Oct 21, 2009 at 2:15 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> I seem to have ack'ed this one too early. After testing in my environment,
>> I get:
>>
>> imap-send.o: In function `ssl_socket_perror':
>> D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_get_error'
>> D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_error_string'
>>
>> I need this patch in addition, and perhaps something similar is also
>> needed with MSVC:
>
> Ah, yes - thanks for that one. I traced it a bit, and I found that it
> works for me without your patch because I'm using OpenSSL's sha1, so
> $(LIB_4_CRYPTO) is already included. Your fix is of course correct.
> I'll squash it in and resend.
Indeed, I observed the failure after I set BLK_SHA1=YesPlease. I did this
exactly because it removes the dependency on libcrypto.dll from git.exe.
-- Hannes
next prev parent reply other threads:[~2009-10-21 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 15:42 [PATCH v4 0/8] imap-send: Windows support Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 1/8] imap-send: remove useless uid code Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 2/8] imap-send: use separate read and write fds Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 3/8] imap-send: use run-command API for tunneling Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 4/8] imap-send: fix compilation-error on Windows Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 5/8] imap-send: build imap-send " Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 6/8] mingw: wrap SSL_set_(w|r)fd to call _get_osfhandle Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 7/8] mingw: enable OpenSSL Erik Faye-Lund
2009-10-19 15:42 ` [PATCH v4 8/8] MSVC: Enable OpenSSL, and translate -lcrypto Erik Faye-Lund
2009-10-19 18:20 ` [msysGit] [PATCH v4 7/8] mingw: enable OpenSSL Johannes Sixt
2009-10-21 12:15 ` Johannes Sixt
2009-10-21 12:43 ` Erik Faye-Lund
2009-10-21 12:55 ` Johannes Sixt [this message]
2009-10-19 18:20 ` [msysGit] [PATCH v4 6/8] mingw: wrap SSL_set_(w|r)fd to call _get_osfhandle Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADF04BB.10302@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=mstormo@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.