From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uri Lublin Subject: Re: [Autotest] [PATCH] Test 802.1Q vlan of nic Date: Wed, 21 Oct 2009 15:46:56 +0200 Message-ID: <4ADF10D0.3080405@redhat.com> References: <301351519.552421256044394416.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <1934714265.553191256044790508.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <20091021103756.GB2641@dhcp-66-70-48.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Michael Goldish , kvm@vger.kernel.org, dlaor@redhat.com To: Amos Kong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64373 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753301AbZJUNrJ (ORCPT ); Wed, 21 Oct 2009 09:47:09 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9LDlDmp007621 for ; Wed, 21 Oct 2009 09:47:13 -0400 In-Reply-To: <20091021103756.GB2641@dhcp-66-70-48.nay.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/21/2009 12:37 PM, Amos Kong wrote: > On Tue, Oct 20, 2009 at 09:19:50AM -0400, Michael Goldish wrote: >> ----- "Dor Laor" wrote: >>> On 10/15/2009 11:48 AM, Amos Kong wrote: >> For the sake of safety maybe we should start both VMs with -snapshot. >> Dor, what do you think? Is it safe to start 2 VMs with the same disk image >> when only one of them uses -snapshot? > > Setup the second VM with -snapshot is enough. The image can only be R/W by 1th VM. > Actually, I agree with Michael. If both VMs use the same disk image, it is safer to setup both VMs with "-snapshot". When the first VM writes to the disk-image the second VM may be affected. >>>> + nic_mode = tap >>>> + nic_model = e1000 >>> >>> Why only e1000? Let's test virtio and rtl8139 as well. Can't you >>> inherit the nic model from the config? >> >> It's not just inherited, it's overwritten, because nic_model is defined >> later in the file in a variants block. So this nic_model line has no >> effect. > > No, this line is effective. If reserve this line, this case just test e1000, not the default 8139. It is overwritten for virtio and untouched for rtl8139 (BTW, we need to add rtl8139 definition instead of leaving it empty and use qemu-kvm default nic). If you really want to only test e1000, a filter is more appropriate. Regards, Uri.