Re: [PATCH] e2fsprogs: fix configure.in typo

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:

>> (note; with this, once I try to build w/ a new libblkid, I still
>> get a mkfs build error ... it's still picking up the in-tree blkid
>> headers)
> 
> Hmmm... which in-tree header files is it picking up?  And what error
> are you seeing?
> 
> There are a few header files that I can see that we should probably
> clean-up, but they don't look like they should be problematic.
> 
> build.static/lib/blkid/blkid_types.h -- just simple type definitions
> lib/blkid/blkidP.h ---  only used by lib/blkid/*.c
> lib/blkid/list.h --- only used by lib/blkid/*.c
> lib/blkid/probe.h -- only used by lib/blkid/probe.c

making all in misc
make[2]: Entering directory `/src/git/e2fsprogs/misc'
gcc -c -I../lib -I../lib \
<snip> \
-g -O2 -I./../e2fsck -I.    mke2fs.c -o mke2fs.o
mke2fs.c: In function ‘ext2fs_get_device_geometry’:
mke2fs.c:1033: error: ‘blkid_probe’ undeclared (first use in this function)
mke2fs.c:1033: error: (Each undeclared identifier is reported only once
mke2fs.c:1033: error: for each function it appears in.)
mke2fs.c:1033: error: expected ‘;’ before ‘pr’
mke2fs.c:1034: error: ‘blkid_topology’ undeclared (first use in this
function)
mke2fs.c:1034: error: expected ‘;’ before ‘tp’
mke2fs.c:1038: error: ‘pr’ undeclared (first use in this function)
mke2fs.c:1042: error: ‘tp’ undeclared (first use in this function)
make[2]: *** [mke2fs.o] Error 1
make[2]: Leaving directory `/src/git/e2fsprogs/misc'
make[1]: *** [all-progs-recursive] Error 1
make[1]: Leaving directory `/src/git/e2fsprogs'
make: *** [all] Error 2

seems like it's not picking up the system /usr/include/blkid/blkid.h but
rather e2fsprogs/lib/blkid/blkid.h

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html