All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] qemu: work around for "posix-aio-compat"
Date: Wed, 21 Oct 2009 19:44:14 +0200	[thread overview]
Message-ID: <4ADF486E.9080807@redhat.com> (raw)
In-Reply-To: <20091021173516.GA25112@redhat.com>


>> I suggest trying to make the sigset_t static, since that generates
>> exactly the same code as the "nohang" case, and exactly the same stack
>> layout as the "hang" case.

(In case this wasn't clear: the sigfillset of a static sigset_t should 
hang, proving that it's stack layout that comes to the rescue).

>> The next obvious step would be placing a
>> watchpoint somewhere.
>
> Yes, but where?

At every word of the sigset (using gdb commands to disable/enable the 
watchpoints around the sigfillset, you avoid spurious triggers).  One of 
those words will be overwritten if an overrun would have smashed the 
stack.  If it does not fire, s/sigfillset/sigemptyset/ in case it was 
writing 0xffffffff.  If it still does not fire, dunno. :-(

Paolo

  reply	other threads:[~2009-10-21 17:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 20:37 [Qemu-devel] [PATCH] qemu: work around for "posix-aio-compat" Michael S. Tsirkin
2009-10-08 20:53 ` [Qemu-devel] " malc
2009-10-08 21:13   ` malc
2009-10-08 21:46     ` Michael S. Tsirkin
2009-10-08 22:17       ` malc
2009-10-08 23:19         ` Michael S. Tsirkin
2009-10-09  1:06           ` [Qemu-devel] Emulated network cards Natalia Portillo
2009-10-09  8:54             ` Luca Tettamanti
2009-10-09 13:05               ` Natalia Portillo
2009-10-09 13:16           ` [Qemu-devel] Re: [PATCH] qemu: work around for "posix-aio-compat" malc
2009-10-08 21:00 ` Michael S. Tsirkin
2009-10-20 18:39 ` [Qemu-devel] " Mark McLoughlin
2009-10-20 18:57   ` [Qemu-devel] " Paolo Bonzini
2009-10-21 15:42     ` Michael S. Tsirkin
2009-10-21 15:54       ` Michael S. Tsirkin
2009-10-21 17:28       ` Paolo Bonzini
2009-10-21 17:35         ` Michael S. Tsirkin
2009-10-21 17:44           ` Paolo Bonzini [this message]
2009-10-21 17:46             ` Michael S. Tsirkin
2009-10-21 18:38               ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADF486E.9080807@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=markmc@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.