From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0faC-0001Yp-Et
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:06:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0fa7-0001Rr-33
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:06:47 -0400
Received: from [199.232.76.173] (port=49432 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0fa6-0001Rc-Qx
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:06:42 -0400
Received: from gv-out-0910.google.com ([216.239.58.185]:16046)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1N0fa6-0004Xa-Bk
	for qemu-devel@nongnu.org; Wed, 21 Oct 2009 14:06:42 -0400
Received: by gv-out-0910.google.com with SMTP id s4so858249gve.36
	for <qemu-devel@nongnu.org>; Wed, 21 Oct 2009 11:06:40 -0700 (PDT)
Message-ID: <4ADF4DAA.1030501@codemonkey.ws>
Date: Wed, 21 Oct 2009 13:06:34 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/9] Export function for VA defined ram
	allocation
References: <1256117106-9475-1-git-send-email-agraf@suse.de>
	<1256117106-9475-2-git-send-email-agraf@suse.de>
	<4ADF1AE4.8020004@codemonkey.ws>
	<EAD4B0F9-3F0D-4670-AD78-80FE83192FA6@suse.de>
	<4ADF3CB5.9090700@codemonkey.ws>
	<80C7ACF1-A6F3-4212-8AFB-E97C23C98218@suse.de>
In-Reply-To: <80C7ACF1-A6F3-4212-8AFB-E97C23C98218@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

Alexander Graf wrote:
> So you would prefer a special #ifdef for s390 in generic code over a 
> specifically for this purpose exported function?
>
> Well, you're the boss. I like the special function better, but 
> whatever you say.

How is someone supposed to figure out what _qemu_ram_alloc is for?  
Nothing in your patch really indicates that.

However, an ugly #ifdef immediately tells someone, oh, s390 kvm needs 
this terrible hack, so let's keep bugging those guys to eliminate the 
need for that.

Regards,

Anthony Liguori

> Alex
>