Re: [Qemu-devel] [PATCH 3/3 v4] Enable migration without shared storage from the monitor

[Anthony Liguori <anthony@codemonkey.ws>]

lirans@il.ibm.com wrote:
> This patch adds the option to activate non-shared storage migration from the
> monitor.
> The migration command is as follows:
> (qemu) migrate -d tcp:0:4444 # for ordinary live migration
> (qemu) migrate -d -b tcp:0:4444 # for live migration with complete storage copy
> (qemu) migrate -d -i tcp:0:4444 # for live migration with incremental storage copy, storage is cow based.
>
> Signed-off-by: Liran Schour <lirans@il.ibm.com>
> ---
> diff --git a/monitor.c b/monitor.c
> index 3424e60..ae29181 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2907,6 +2907,18 @@ static int default_fmt_size = 4;
>  
>  #define MAX_ARGS 16
>  
> +static int is_valid_option(const char *c, const char *typestr)
> +{
> +  char option[3];
> +  
> +  option[0] = '-';
> +  option[1] = *c;
> +  option[2] = '\0';
> +  
> +  typestr = strstr(typestr, option);
> +  return (typestr != NULL);
> +}
>   

This is pretty darn funky.  Can you explain why this is needed?

Regards,

Anthony Liguori