From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix DM9000 MAC address handling
Date: Wed, 21 Oct 2009 20:48:38 -0700 [thread overview]
Message-ID: <4ADFD616.60505@gmail.com> (raw)
In-Reply-To: <200910212331.09485.vapier@gentoo.org>
Mike Frysinger wrote:
> On Wednesday 21 October 2009 20:25:09 Ben Warren wrote:
>
>> +void dm9000_get_enetaddr(struct eth_device *dev)
>>
>
> static ?
>
>
Yeah, this was thrown together pretty quickly...
>> +#if !defined(CONFIG_DM9000_NO_SROM)
>> + int i;
>> + for (i = 0; i < 3; i++) {
>> + dm9000_read_srom_word(i, dev->enetaddr + (2 * i));
>> + }
>>
>
> dont need the braces ...
>
OK
> -mike
>
thanks for the review,
Ben
prev parent reply other threads:[~2009-10-22 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 0:25 [U-Boot] [PATCH] Fix DM9000 MAC address handling Ben Warren
2009-10-22 3:31 ` Mike Frysinger
2009-10-22 3:48 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADFD616.60505@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.