From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N0r3g-0004WX-Ro
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 02:22:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N0r3c-0004Vr-57
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 02:22:00 -0400
Received: from [199.232.76.173] (port=49302 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N0r3b-0004Vo-R8
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 02:21:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46413)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1N0r3b-0005Dz-F0
	for qemu-devel@nongnu.org; Thu, 22 Oct 2009 02:21:55 -0400
Message-ID: <4ADFF9FE.6090901@redhat.com>
Date: Thu, 22 Oct 2009 08:21:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1255516409-19166-1-git-send-email-quintela@redhat.com>	<1256055443-5563-1-git-send-email-weil@mail.berlios.de>	<4ADDF521.1070307@redhat.com>
	<4ADF7A62.8000706@mail.berlios.de>
In-Reply-To: <4ADF7A62.8000706@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Makefile: Change make to be quiet again
 when doing nothing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 10/21/2009 11:17 PM, Stefan Weil wrote:
> Paolo Bonzini schrieb:
>> On 10/20/2009 06:17 PM, Stefan Weil wrote:
>>> This patch makes make quiet again.
>>>
>>> There is already a similar patch from Juan Quintela,
>>> but maybe this shorter form is preferred.
>>
>> This patch would reintroduce an ordering problem between building
>> config*.h and building the tools, whose fix is what made "make" noisy
>> in the first place.
>>
>> Paolo
>
> Did you try this? config*.h will be built first, tools and docs come
> later with my patch,
> so there should not be any difference regarding the build order.

No, but if there is a hidden missing dependency I don't see how your 
patch could work, that's it.  I know that the patch is "in theory" 
correct, but people were reporting failed builds and Juan's move of 
$(TOOLS) $(DOCS) solved it.

Consider in addition that make does not guarantee to even *start* A 
before B if you have "TARGET: A B", especially at very high parallelism. 
  If you have icecream installed, a make -j20 is not uncommon and 
guaranteed to find wrong dependencies.

Paolo