From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0thK-0007nF-Jd for qemu-devel@nongnu.org; Thu, 22 Oct 2009 05:11:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0thG-0007m0-In for qemu-devel@nongnu.org; Thu, 22 Oct 2009 05:11:06 -0400 Received: from [199.232.76.173] (port=42296 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0thG-0007lv-Dw for qemu-devel@nongnu.org; Thu, 22 Oct 2009 05:11:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42721) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0thF-0006yS-EH for qemu-devel@nongnu.org; Thu, 22 Oct 2009 05:11:01 -0400 Message-ID: <4AE0218D.5080604@redhat.com> Date: Thu, 22 Oct 2009 11:10:37 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks References: <145D39CA-6310-4B12-9AFF-32FAAB8C286D@nokia.com> <4AE011FB.6020508@redhat.com> <75207884-F7E7-45F4-BBD7-D13CB9FBECA9@nokia.com> In-Reply-To: <75207884-F7E7-45F4-BBD7-D13CB9FBECA9@nokia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juha.Riihimaki@nokia.com Cc: qemu-devel@nongnu.org On 10/22/09 10:35, Juha.Riihimaki@nokia.com wrote: >> Hi, >> >>> -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, >>> tcg_const_i32(mask)) >> >> Your mailer mangles the patches. > > Yes, I know, I can't help it, I'm sorry. Makes it very difficult to extract the patches in a automated way ... > That's why I include the > patch as an attachment as well -- the attachment should stay in > working condition I think. I put the patches inline as well to make it > possible to look at the patches without the need to separately open > the attachment; whether you need to do that or not depends on the mail > client, I suppose a client could also show text attachment inline. Depends on the mailer too ... Yours sends the attached patch with ... "Content-Disposition: attachment; filename=...." When sent as "Content-Disposition: inline" mail clients will display the attachment inline. cheers, Gerd