All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers
Date: Thu, 22 Oct 2009 14:15:06 +0200	[thread overview]
Message-ID: <4AE04CCA.7030300@redhat.com> (raw)
In-Reply-To: <20091022112327.GG8092@mothafucka.localdomain>

>> Just defining the msrs instead of using kvm_para.h should be fine, the
>> numbers will not change ...
> That's not the problem. If one removes kvm_para.h, a lot of other things
> will not build. For example, the capabilities list.
> And it has been like this for almost a year now!
>
> Without that header, your system should have never successfully built a
> qemu-kvm instance. This is what happens here, if I try to remove it:

qemu != qemu-kvm.

qemu-kvm ships with a copy of the kvm kernel header files.
upstream qemu doesn't.

cheers,
   Gerd

  reply	other threads:[~2009-10-22 12:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 14:04 [Qemu-devel] [PATCH] properly save kvm system time msr registers Glauber Costa
2009-10-21 13:38 ` Gerd Hoffmann
2009-10-21 14:32   ` Glauber Costa
2009-10-21 14:52     ` Gerd Hoffmann
2009-10-21 14:57       ` Glauber Costa
2009-10-21 19:39       ` Glauber Costa
2009-10-22  8:00         ` Gerd Hoffmann
2009-10-22 11:23           ` Glauber Costa
2009-10-22 12:15             ` Gerd Hoffmann [this message]
2009-10-22 12:21               ` Glauber Costa
2009-10-22 12:22               ` Glauber Costa
2009-10-22 14:08             ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE04CCA.7030300@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=glommer@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.