Re: [PATCH 1/2] kvm-kmod: Use the main development tree of kvm as Linux submodule

[Avi Kivity <avi@redhat.com>]

On 10/22/2009 06:13 PM, Wolfgang Mauerer wrote:
> Hi,
>
> Avi Kivity wrote:
>    
>> On 10/20/2009 02:11 PM, wolfgang.mauerer@siemens.com wrote:
>>      
>>> From: Wolfgang Mauerer<wolfgang.mauerer@siemens.com>
>>>
>>> Most people won't have the sources installed in the path
>>> that is the current default setting.
>>>
>>> --- a/.gitmodules
>>> +++ b/.gitmodules
>>> @@ -1,3 +1,3 @@
>>>    [submodule "linux-2.6"]
>>>    	path = linux-2.6
>>> -	url = ../kvm.git
>>> +	url = git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git
>>>
>>>        
>> '../kvm.git' is interpreted relative to the origin url, which is usually
>> git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm-kmod.git, so it
>> all works out (including when kvm-kmod.git was cloned using the http
>> protocol, or from a mirror).
>>
>> What exactly are you trying to fix?
>>      
> consider that you clone kvm-kmod from your repo and
> then create local clones from which you do the build. If you don't
> happen to have /path/to/my/kvm-kmod/../kvm, then the relative
> submodule URL won't work, but the absolute one will.
>    

Typically you create the clones using 'git submodule init && git 
submodule update', not clone them manually.

> Since the absolute URL wouldn't break anything AFAIK, but
> makes this scenario work, I'd favour it, although my
> life would not be much worse with the relative default
> URL ;-)
>    

You can still make it work by editing .git/config and updating the URLs.

-- 
error compiling committee.c: too many arguments to function