From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allow userspace to adjust kvmclock offset
Date: Thu, 22 Oct 2009 18:23:36 +0200 [thread overview]
Message-ID: <4AE08708.6070302@redhat.com> (raw)
In-Reply-To: <20091015145855.GI8092@mothafucka.localdomain>
On 10/15/2009 04:58 PM, Glauber Costa wrote:
>
>> The motivation for relative adjustment is when you have a jitter
>> resistant place to gather timing information (like the kernel, which can
>> disable interrupts and preemption), then pass it on to kvm without
>> losing information due to scheduling. For migration there is no such
>> place since it involves two hosts, but it makes sense to support
>> relative adjustments.
>>
> Since we added the padding you asked for, we could use that bit of information
> to define whether it will be a relative or absolute adjustment, then. Right now,
> I don't see the point of implementing a code path that will be completely untested.
>
> I'd leave it this way until someone comes up with a need.
>
I agree with that, but padding by itself is insufficient. You also need
a flags field.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-10-22 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 17:24 [PATCH] allow userspace to adjust kvmclock offset Glauber Costa
2009-10-12 8:53 ` Avi Kivity
2009-10-13 12:28 ` Glauber Costa
2009-10-13 12:31 ` Avi Kivity
2009-10-13 12:46 ` Glauber Costa
2009-10-15 0:46 ` Avi Kivity
2009-10-15 14:58 ` Glauber Costa
2009-10-22 16:23 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE08708.6070302@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.