All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>,
	netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] atm: Cleanup redundant tests on unsigned
Date: Fri, 23 Oct 2009 18:08:30 +0200	[thread overview]
Message-ID: <4AE1D4FE.5090902@gmail.com> (raw)
In-Reply-To: <4AE1D553.8010406@gmail.com>

Roel Kluin a écrit :
> The variables are unsigned so the `< 0' test always fails, the
> other part of the test catches wrapped values.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---

I believe such patches were posted in the past.

General consensus is that compiler is able to do this optimization for us,
and reader doesnt have to ask to himself : "Is the test safe enough ?"


  reply	other threads:[~2009-10-23 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23 16:09 [PATCH] atm: Cleanup redundant tests on unsigned Roel Kluin
2009-10-23 16:08 ` Eric Dumazet [this message]
2009-10-24 13:19   ` David Miller
2009-10-29  8:40 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE1D4FE.5090902@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=netdev@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.