From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH] Fix total byte read/write count for large checkpoint images Date: Fri, 23 Oct 2009 14:44:13 -0400 Message-ID: <4AE1F97D.7090902@librato.com> References: <1256315918-3378-1-git-send-email-matthltc@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1256315918-3378-1-git-send-email-matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Pulled, thanks. Matt Helsley wrote: > Though currently unused, total relies on checkpoint images being less > than 2GB. Since we've had 64-bit archs and LARGEFILE support for some > time it's not totally unreasonable to make this a 64-bit quantity. > > Signed-off-by: Matt Helsley > --- > include/linux/checkpoint_types.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/checkpoint_types.h b/include/linux/checkpoint_types.h > index fa57cdc..5cc11d9 100644 > --- a/include/linux/checkpoint_types.h > +++ b/include/linux/checkpoint_types.h > @@ -48,7 +48,7 @@ struct ckpt_ctx { > unsigned long oflags; /* restart: uflags from checkpoint */ > > struct file *file; /* input/output file */ > - int total; /* total read/written */ > + loff_t total; /* total read/written */ > > atomic_t refcount; >