All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernard Pidoux F6BVP <f6bvp@free.fr>
To: Linux Hams <linux-hams@vger.kernel.org>
Cc: Ralf Baechle DL5RB <ralf@linux-mips.org>, ax25@x-berg.in-berlin.de
Subject: [BUG] ax25-tools-0.0.10-rc2 : no netrom device attached
Date: Sun, 25 Oct 2009 11:26:28 +0100	[thread overview]
Message-ID: <4AE427D4.4040802@free.fr> (raw)

Hi,

nrattach does not create any nr# device despite a success message :

ax25-tools-0.0.10-rc2]# netrom/nrattach -m 236 netbbs
NET/ROM port netbbs bound to device nr2

ifconfig does not show any nr device !

Investigating nrattach source file revealed that a conditional compile
instruction was added.

Actually, #ifdef instruction included in nrattach.c prevents 
a call to startiface() funtion to be compiled.
This is because "notdef" is actually not defined by default.

I don't know exactly why this was added in nrattach source file but,
to keep backward compatibility with previous versions, the proposition
should be reversed, i.e. #ifdef replaced by #ifndef. 

The new code would look like the following :

#ifndef notdef
	if (!startiface(dev, hp))
		return 1;		
#endif
	printf("NET/ROM port %s bound to device %s\n", argv[optind], dev);

However, if notdef is defined somewhere, there will be again no netrom device
created, but a false success message will still be displayed.

I don't really understand the purpose of this.

73 de Bernard, f6bvp

                 reply	other threads:[~2009-10-25 10:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE427D4.4040802@free.fr \
    --to=f6bvp@free.fr \
    --cc=ax25@x-berg.in-berlin.de \
    --cc=linux-hams@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.