Re: [PATCH] Fix siginfo._uid bug

[Maxim Kuvyrkov <maxim@codesourcery.com>]

Maxim Kuvyrkov wrote:
> Maxim Kuvyrkov wrote:
>> Andreas Schwab wrote:
>>> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
>>>
>>>> The bug is rather elegant and has been present in sources for years.
>>>
>>> For more than 9 years, to be precise, when 32 bit uids were introduced.
> ...
>>> Given that there is no way to keep backward compatibility it might be a
>>> good opportunity to do same cleanup here.  Like going back to the
>>> generic layout.
>>
>> There is yet another bug in siginfo.  si_sigval is expected to be at 
>> the same offsets in _timer and _rt.  At the moment si_sigval is at 
>> offset 8 in _timer and at offset 6 in _rt (the patch for fixing uids 
>> makes that 8@_timer and 10@_rt).
>>
>> This bug causes rt/tst-*timer* tests fail.
>>
>> Moving on to the generic version of siginfo.h will certainly fix the 
>> problem, otherwise, one needs to pad extra 2 bytes in _timer.
> 
> While the discussion is pending, here is an updated version of the patch 
> that also patches up sigval.

Ping?  Broken signal handling is a quite serious bug.

Geert, which option of fixing would you prefer?

-- 
Maxim Kuvyrkov
CodeSourcery
maxim@codesourcery.com
(650) 331-3385 x724