All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
Date: Tue, 27 Oct 2009 09:07:43 -0500	[thread overview]
Message-ID: <4AE6FEAF.5040501@windriver.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E73940436E5F625@dbde02.ent.ti.com>

Gupta, Ajay Kumar wrote:
> Tom,
>> From: Tom Rix <Tom.Rix <at> windriver.com>
>> Subject: [PATCH 6/8] OMAP3 beagle Add usbtty configuration
>> Newsgroups: gmane.comp.boot-loaders.u-boot
>> Date: 2009-09-28 16:37:27 GMT (4 weeks, 12 hours and 41 minutes ago)
>>
>> The primary console of beagle is the serial header.
>>
>> A secondary console is to use the usbtty.  The user can set this
>> manually by doing
>>
>> setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
>> saveenv
>>
>> usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.
>>
>> Signed-off-by: Tom Rix <Tom.Rix <at> windriver.com>
>> ---
>>  include/configs/omap3_beagle.h |   16 ++++++++++++++++
>>  1 files changed, 16 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/omap3_beagle.h
>> b/include/configs/omap3_beagle.h
>> index 55eeb94..253cdba 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -98,6 +98,21 @@
>>  #define CONFIG_OMAP3_MMC		1
>>  #define CONFIG_DOS_PARTITION		1
>>
>> +/* USB */
>> +#define CONFIG_MUSB_UDC			1
>> +#define CONFIG_USB_OMAP3		1
>> +#define CONFIG_TWL4030_USB		1
>> +
>> +/* USB device configuration */
>> +#define CONFIG_USB_DEVICE		1
>> +#define CONFIG_USB_TTY			1
>> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
>> +/* Change these to suit your needs */
>> +#define CONFIG_USBD_VENDORID		0x0451
>> +#define CONFIG_USBD_PRODUCTID		0x5678
>> +#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
>> +#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
>> +
> 
> We can either define CONFIG_MUSB_UDC or CONFIG_MUSB_HCD (host support), so I think it's better to move host and device specific definitions within
> CONFIG_MUSB_UDC or CONFIG_MUSB_HCD.
> 
> #ifdef CONFIG_USB_OMAP3
> 
> #ifdef  CONFIG_MUSB_HCD
> <here define all host specific definitions>
> #endif
> 
> #ifdef  CONFIG_MUSB_UDC
> <here define all device specific definitions>
> #endif
> 
> #endif /* CONFIG_USB_OMAP3 */
> 
> This change would make it easier to test Host or device functionalities.
> 
> -Ajay

I am not adding host support.
Tom

  reply	other threads:[~2009-10-27 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <19F8576C6E063C45BE387C64729E73940436E5F620@dbde02.ent.ti.com>
2009-10-27  5:25 ` [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration Gupta, Ajay Kumar
2009-10-27 14:07   ` Tom [this message]
2009-10-28  8:52     ` Gupta, Ajay Kumar
2009-09-28 16:37 [U-Boot] V2 of OMAP3 USB device Support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-28 16:37   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-28 16:37     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-28 16:37       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-28 16:37         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-28 16:37           ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
  -- strict thread matches above, loose matches on Subject: below --
2009-09-28 16:34 [U-Boot] V2 of OMAP3 USB device Support y at windriver.com
2009-09-28 16:34 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions y at windriver.com
2009-09-28 16:34   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup y at windriver.com
2009-09-28 16:34     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support y at windriver.com
2009-09-28 16:34       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support y at windriver.com
2009-09-28 16:35         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration y at windriver.com
2009-09-28 16:35           ` [U-Boot] [PATCH 6/8] OMAP3 beagle " y at windriver.com
2009-09-04 20:12 [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-04 20:12 ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-04 20:12   ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-04 20:12     ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-04 20:12       ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-04 20:12         ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
2009-09-05  0:26           ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE6FEAF.5040501@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.