From: James Smart <James.Smart@Emulex.Com>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: fc_remote_port_delete and returning SCSI commands from LLD
Date: Tue, 27 Oct 2009 15:44:52 -0400 [thread overview]
Message-ID: <4AE74DB4.4030908@emulex.com> (raw)
In-Reply-To: <20091027165943.GA21795@schmichrtp.de.ibm.com>
Thanks Christof.
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Christof Schmitt wrote:
> On Fri, Oct 23, 2009 at 10:50:15AM -0400, James Smart wrote:
>> Christof Schmitt wrote:
>>> It looks to me like this is required to prevent offline SCSI devices
>>> in this case. Should this code be in a FC transport helper function
>>> rather than being duplicated in each FC LLD?
>> That would make sense....
>>
>> -- james s
>
> Here is a patch for this. It is only compile tested on x86, but the
> code move is fairly trivial.
>
> Christof
> ---
> scsi_transport_fc: Introduce helper function for blocking scsi_eh
>
> From: Christof Schmitt <christof.schmitt@de.ibm.com>
>
> Move the duplicated code from FC LLDs to SCSI FC transport class.
>
> Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 20 ++------------------
> drivers/scsi/lpfc/lpfc_scsi.c | 30 ++++--------------------------
> drivers/scsi/qla2xxx/qla_os.c | 25 ++++---------------------
> drivers/scsi/scsi_transport_fc.c | 26 ++++++++++++++++++++++++++
> include/scsi/scsi_transport_fc.h | 1 +
> 5 files changed, 37 insertions(+), 65 deletions(-)
>
next prev parent reply other threads:[~2009-10-27 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 14:40 fc_remote_port_delete and returning SCSI commands from LLD Christof Schmitt
2009-10-21 15:24 ` Christof Schmitt
2009-10-21 16:33 ` James Smart
2009-10-23 7:58 ` Christof Schmitt
2009-10-23 14:50 ` James Smart
2009-10-27 16:59 ` Christof Schmitt
2009-10-27 19:44 ` James Smart [this message]
2009-10-21 16:24 ` James Smart
2009-10-23 7:47 ` Christof Schmitt
2009-10-23 14:47 ` James Smart
2009-10-27 21:57 ` Mike Christie
2009-10-21 18:11 ` Mike Christie
2009-10-23 7:13 ` Christof Schmitt
2009-10-27 21:53 ` Mike Christie
2009-10-28 14:27 ` Christof Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE74DB4.4030908@emulex.com \
--to=james.smart@emulex.com \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.