From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@novell.com>
Subject: '!' as separator for sxp?
Date: Tue, 27 Oct 2009 15:25:30 -0600
Message-ID: <4AE7654A.5010607@novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------090606040503010802090208"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------090606040503010802090208
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

I'm trying to determine if '!' is in fact a separator in domain sxp. 
According to is_separator() in tools/python/xen/xend/sxp.py it is

    def is_separator(self, c):
        return self.in_class(c, '{}()<>[]!;')

But '!' is a valid character in domain sxp, e.g.

(vbd
  (protocol x86_64-abi)
  ...
  (mode w!)
  ...
)

With '!' being a separator, mode must be quoted in order to parse the
above sxp config correctly.  I cannot find any other use of '!' in
domain sxp - and certainly no use of it as a separator.

Does anyone know of the use of '!' as a separator?  If not, the attached
patch removes it from is_separator().

Regards,
Jim


    Signed-off-by: Jim Fehlig <jfehlig@novell.com>




--------------090606040503010802090208
Content-Type: text/x-patch;
 name="sxp.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="sxp.patch"

diff -r c4958b2edaa5 tools/python/xen/xend/sxp.py
--- a/tools/python/xen/xend/sxp.py	Tue Oct 27 12:52:57 2009 +0000
+++ b/tools/python/xen/xend/sxp.py	Tue Oct 27 15:23:37 2009 -0600
@@ -142,7 +142,7 @@
         return self.in_class(c, ' \t\n\v\f\r')
 
     def is_separator(self, c):
-        return self.in_class(c, '{}()<>[]!;')
+        return self.in_class(c, '{}()<>[];')
 
     def in_comment_class(self, c):
         return self.in_class(c, '#')

--------------090606040503010802090208
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------090606040503010802090208--