From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Andreas Petlund <apetlund@simula.no>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shemminger@vyatta.com, ilpo.jarvinen@helsinki.fi,
davem@davemloft.net
Subject: Re: [PATCH 1/3] net: TCP thin-stream detection
Date: Tue, 27 Oct 2009 23:09:10 -0400 [thread overview]
Message-ID: <4AE7B5D6.8070001@gmail.com> (raw)
In-Reply-To: <4AE72075.4070702@simula.no>
Andreas Petlund wrote:
> +/* Determines whether this is a thin stream (which may suffer from
> + * increased latency). Used to trigger latency-reducing mechanisms.
> + */
> +static inline unsigned int tcp_stream_is_thin(const struct tcp_sock *tp)
> +{
> + return tp->packets_out < 4;
> +}
> +
This bothers me a bit. Having just looked at your Linux presentation,
and not (yet) read your papers, it seems much of your justification was
with 1 packet per RTT. Here, you seem to be concentrating on 4, probably
because many implementations quickly ramp up to 4.
But there's a fair amount of experience showing that ramping to 4 is
problematic on congested paths, especially wireless networks. Fast
retransmit in that case would be disastrous.
Once upon a time, I worked on a fair number of interactive games a decade
or so ago. And agree that this can be a problem, although I've never
been a fan of turning off the Nagle algorithm. My solution has always
been a heartbeat, rather than trying to shoehorn this into TCP.
Also, I've not seen any discussion on the end-to-end interest list.
next prev parent reply other threads:[~2009-10-28 3:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 16:31 [PATCH 1/3] net: TCP thin-stream detection Andreas Petlund
2009-10-28 3:09 ` William Allen Simpson [this message]
2009-10-29 13:51 ` Andreas Petlund
2009-10-29 16:32 ` Arnd Hannemann
2009-10-29 20:26 ` Ilpo Järvinen
-- strict thread matches above, loose matches on Subject: below --
2009-10-30 13:53 apetlund
2009-10-30 15:24 ` Arnd Hannemann
2009-11-05 13:34 ` Andreas Petlund
2009-11-05 13:45 ` Ilpo Järvinen
2009-11-09 15:24 ` Andreas Petlund
2009-10-30 15:23 apetlund
2009-10-30 16:13 ` William Allen Simpson
2009-11-05 13:36 ` Andreas Petlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE7B5D6.8070001@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=apetlund@simula.no \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.