From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
hpa@zytor.com, mingo@redhat.com, tzanussi@gmail.com,
peterz@infradead.org, fweisbec@gmail.com, rostedt@goodmis.org,
tglx@linutronix.de
Subject: Re: [tip:perf/core] tracing/filters: Refactor subsystem filter code
Date: Wed, 28 Oct 2009 17:06:27 +0800 [thread overview]
Message-ID: <4AE80993.5000300@cn.fujitsu.com> (raw)
In-Reply-To: <20091015103614.GA20291@elte.hu>
Ingo Molnar wrote:
> * tip-bot for Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> Commit-ID: fce29d15b59245597f7f320db4a9f2be0f5fb512
>> Gitweb: http://git.kernel.org/tip/fce29d15b59245597f7f320db4a9f2be0f5fb512
>> Author: Li Zefan <lizf@cn.fujitsu.com>
>> AuthorDate: Thu, 15 Oct 2009 11:20:34 +0800
>> Committer: Ingo Molnar <mingo@elte.hu>
>> CommitDate: Thu, 15 Oct 2009 11:35:22 +0200
>
> the filter variable was not initialized here - i have applied the fix
> below.
>
I sent out the patchset and then went for a travel, and came back
to found this fixup is wrong..
I'll send out the correct fix soon.
> Ingo
>
> Index: linux/kernel/trace/trace_events_filter.c
> ===================================================================
> --- linux.orig/kernel/trace/trace_events_filter.c
> +++ linux/kernel/trace/trace_events_filter.c
> @@ -1230,8 +1230,8 @@ static int replace_system_preds(struct e
> struct filter_parse_state *ps,
> char *filter_string)
> {
> + struct event_filter *filter = system->filter;
> struct ftrace_event_call *call;
> - struct event_filter *filter;
> int err;
> bool fail = true;
>
>
>
next prev parent reply other threads:[~2009-10-28 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 3:19 [PATCH 0/4] perf trace: Add filter Suppport, V3 Li Zefan
2009-10-15 3:20 ` [PATCH 1/4] tracing/filters: Refactor subsystem filter code Li Zefan
2009-10-15 9:39 ` [tip:perf/core] " tip-bot for Li Zefan
2009-10-15 10:36 ` Ingo Molnar
2009-10-28 9:06 ` Li Zefan [this message]
2009-10-15 3:21 ` [PATCH 2/4] tracing/filters: Use a different op for glob match Li Zefan
2009-10-15 9:40 ` [tip:perf/core] " tip-bot for Li Zefan
2009-10-15 12:52 ` [PATCH 2/4] " Frederic Weisbecker
2009-10-15 3:21 ` [PATCH 3/4] tracing/profile: Add filter support Li Zefan
2009-10-15 9:40 ` [tip:perf/core] " tip-bot for Li Zefan
2009-10-15 9:47 ` [PATCH 3/4] " Américo Wang
2009-10-15 3:22 ` [PATCH 4/4] perf trace: Add filter Suppport Li Zefan
2009-10-15 9:40 ` [tip:perf/core] " tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE80993.5000300@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.