From: Aaro Koskinen <aaro.koskinen@nokia.com>
To: "ext Govindraj.R" <govindraj.raja@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCHv2 1/3] OMAP UART: Add omap-serial driver support.
Date: Wed, 28 Oct 2009 14:32:28 +0200 [thread overview]
Message-ID: <4AE839DC.7060906@nokia.com> (raw)
In-Reply-To: <35817.192.168.10.88.1256713979.squirrel@dbdmail.itg.ti.com>
Hello,
Govindraj.R wrote:
> This patch adds support for OMAP3430-HIGH SPEED UART Controller.
>
> Signed-off-by: Govindraj R <govindraj.raja@ti.com>
Could you fix these checkpatch errors:
ERROR: need consistent spacing around '|' (ctx:VxW)
#477: FILE: drivers/serial/omap-serial.c:238:
+ } while ((lsr & (UART_LSR_DR| UART_LSR_BI)) && (max_count-- > 0));
^
ERROR: space required after that ',' (ctx:VxV)
#1093: FILE: drivers/serial/omap-serial.c:854:
+ serial_out(up, UART_OMAP_WER,0x7f);
^
WARNING: suspect code indent for conditional statements (8, 17)
#1719: FILE: drivers/serial/omap-serial.c:1480:
+ if (!uart->context_valid)
+ return;
total: 2 errors, 1 warnings, 1975 lines checked
Thanks,
A.
next prev parent reply other threads:[~2009-10-28 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 7:12 [PATCHv2 1/3] OMAP UART: Add omap-serial driver support Govindraj.R
2009-10-28 10:15 ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-10-28 11:30 ` Govindraj
2009-10-28 12:03 ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-10-28 12:32 ` Aaro Koskinen [this message]
2009-10-28 12:56 ` Kauppi Ari (EXT-Ixonos/Oulu)
2009-10-28 15:53 ` Kevin Hilman
2009-11-02 7:20 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE839DC.7060906@nokia.com \
--to=aaro.koskinen@nokia.com \
--cc=govindraj.raja@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.