From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Date: Wed, 28 Oct 2009 15:03:04 +0000 Subject: Re: [PATCH -next] ia64/sn: fix percpu warnings Message-Id: <4AE85D28.90809@kernel.org> List-Id: References: <20091014163445.f0441473.sfr@canb.auug.org.au> <20091014151003.0ef42973.randy.dunlap@oracle.com> <4AD67C05.2030201@kernel.org> <12c511ca0910261124p64f2ad5emc88d00b9957482b3@mail.gmail.com> <57C9024A16AD2D4C97DC78E552063EA3E345953E@orsmsx505.amr.corp.intel.com> In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3E345953E@orsmsx505.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Luck, Tony" Cc: Randy Dunlap , Stephen Rothwell , Jes Sorensen , "linux-ia64@vger.kernel.org" , "linux-next@vger.kernel.org" , LKML , akpm Hello, Luck, Tony wrote: >> WARNING: "per_cpu____sn_cnodeid_to_nasid" [drivers/misc/sgi-xp/xpc.ko] has no CRC! > > Note that this warning goes away if I fix the mismatch declaration so > that we have: > > DECLARE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]); > in arch.h > > and > > DEFINE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]); > in setup.c Umm... the correct correct declaration and definition would be DECLARE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid); and DEFINE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid); So that the first part contains full type. Doing it the other way might cause problems if the __weak trick is turned on. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH -next] ia64/sn: fix percpu warnings Date: Wed, 28 Oct 2009 16:03:04 +0100 Message-ID: <4AE85D28.90809@kernel.org> References: <20091014163445.f0441473.sfr@canb.auug.org.au> <20091014151003.0ef42973.randy.dunlap@oracle.com> <4AD67C05.2030201@kernel.org> <12c511ca0910261124p64f2ad5emc88d00b9957482b3@mail.gmail.com> <57C9024A16AD2D4C97DC78E552063EA3E345953E@orsmsx505.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:39921 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbZJ1PDE (ORCPT ); Wed, 28 Oct 2009 11:03:04 -0400 In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3E345953E@orsmsx505.amr.corp.intel.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: "Luck, Tony" Cc: Randy Dunlap , Stephen Rothwell , Jes Sorensen , "linux-ia64@vger.kernel.org" , "linux-next@vger.kernel.org" , LKML , akpm Hello, Luck, Tony wrote: >> WARNING: "per_cpu____sn_cnodeid_to_nasid" [drivers/misc/sgi-xp/xpc.ko] has no CRC! > > Note that this warning goes away if I fix the mismatch declaration so > that we have: > > DECLARE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]); > in arch.h > > and > > DEFINE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]); > in setup.c Umm... the correct correct declaration and definition would be DECLARE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid); and DEFINE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid); So that the first part contains full type. Doing it the other way might cause problems if the __weak trick is turned on. Thanks. -- tejun