From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation Date: Thu, 29 Oct 2009 09:47:19 +0100 Message-ID: <4AE95697.6020602@redhat.com> References: <4AE71116.6080809@suse.de> <4AE72419.60608@redhat.com> <20091028091129.n46xqd1lww8oosc8@imap.suse.de> <4AE822E7.2010108@redhat.com> <4AE84E09.7090002@redhat.com> <20091028202522.r53660olwsk8cokk@imap.suse.de> <20091029043708.GA3552@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Hannes Reinecke , qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Christoph Hellwig Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28126 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbZJ2IsL (ORCPT ); Thu, 29 Oct 2009 04:48:11 -0400 In-Reply-To: <20091029043708.GA3552@lst.de> Sender: kvm-owner@vger.kernel.org List-ID: On 10/29/09 05:37, Christoph Hellwig wrote: > - try to create generic scsi device/request structures that the hba > driver can access, and which contain additional private data for > scsi-disk/generic. Information in the generic one would include > the information about the data transfer, the tag and the command > block. Agreed. For scsi device this did already happen as part of the qdev-ification work. It certainly makes sense to do that for scsi requests too. May also allow to kill some code duplication in scsi-disk.c and scsi-generic.c > - try to get rid of the tag indexing stuff by just using a pointer to > the generic scsi request in the hba drivers. That should get rid > of a lot of useless list searching. Indeed. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3Qg8-00034R-LQ for qemu-devel@nongnu.org; Thu, 29 Oct 2009 04:48:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3Qg3-0002yj-Gp for qemu-devel@nongnu.org; Thu, 29 Oct 2009 04:48:19 -0400 Received: from [199.232.76.173] (port=49676 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3Qg3-0002yb-8K for qemu-devel@nongnu.org; Thu, 29 Oct 2009 04:48:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11894) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3Qg2-0003Tc-QI for qemu-devel@nongnu.org; Thu, 29 Oct 2009 04:48:15 -0400 Message-ID: <4AE95697.6020602@redhat.com> Date: Thu, 29 Oct 2009 09:47:19 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation References: <4AE71116.6080809@suse.de> <4AE72419.60608@redhat.com> <20091028091129.n46xqd1lww8oosc8@imap.suse.de> <4AE822E7.2010108@redhat.com> <4AE84E09.7090002@redhat.com> <20091028202522.r53660olwsk8cokk@imap.suse.de> <20091029043708.GA3552@lst.de> In-Reply-To: <20091029043708.GA3552@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: virtualization@lists.linux-foundation.org, Hannes Reinecke , kvm@vger.kernel.org, qemu-devel@nongnu.org On 10/29/09 05:37, Christoph Hellwig wrote: > - try to create generic scsi device/request structures that the hba > driver can access, and which contain additional private data for > scsi-disk/generic. Information in the generic one would include > the information about the data transfer, the tag and the command > block. Agreed. For scsi device this did already happen as part of the qdev-ification work. It certainly makes sense to do that for scsi requests too. May also allow to kill some code duplication in scsi-disk.c and scsi-generic.c > - try to get rid of the tag indexing stuff by just using a pointer to > the generic scsi request in the hba drivers. That should get rid > of a lot of useless list searching. Indeed. cheers, Gerd