From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N3RO2-0005X2-8p for mharc-grub-devel@gnu.org; Thu, 29 Oct 2009 05:33:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3RO0-0005WN-Cy for grub-devel@gnu.org; Thu, 29 Oct 2009 05:33:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3RNv-0005UP-2r for grub-devel@gnu.org; Thu, 29 Oct 2009 05:33:39 -0400 Received: from [199.232.76.173] (port=49298 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3RNu-0005UE-Ft for grub-devel@gnu.org; Thu, 29 Oct 2009 05:33:34 -0400 Received: from ey-out-1920.google.com ([74.125.78.147]:46994) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3RNt-0002Mo-Sy for grub-devel@gnu.org; Thu, 29 Oct 2009 05:33:34 -0400 Received: by ey-out-1920.google.com with SMTP id 3so1927409eyh.34 for ; Thu, 29 Oct 2009 02:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=8ypmpOBZYjlH58Udd1hEH29aLNCA26NMWoTR3/N+veI=; b=A41NpqBPjz1bLFG13ReGWtlEX0vN3sO0EmOKc/Ed5dCNNH4VF9oM8IP4+UoHS5pjqJ s/01WVeR6yzsTXdaseqUoUAYtyX6KWYh34Ko9eJeS+T68PgsQlQ7Eb3JxZV9e8ADHHoZ 4zxnsIGk5OlFrqzaIymvZRQ1g2li1vLme3xBE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=Up1QFKaxk9fEwQzGdgQjni/LMrfCjYwL/Dlu76K09FL7pW7Vz15q54mtGkUvFJv2Vz InzEwC1k+zSR6HLJUFxQHtCZMYoNThL/ObfGEJt5ibIEwpuzqmF7A3+Yvu+xiuS/hpBs Vru7S2cThNqKznFZdGSkhs5lkuTR9So64rPMw= Received: by 10.211.139.17 with SMTP id r17mr7374681ebn.88.1256808812717; Thu, 29 Oct 2009 02:33:32 -0700 (PDT) Received: from debian.bg45.phnet (gprs13.swisscom-mobile.ch [193.247.250.13]) by mx.google.com with ESMTPS id 23sm5216565eya.44.2009.10.29.02.33.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 29 Oct 2009 02:33:31 -0700 (PDT) Message-ID: <4AE96168.8070605@gmail.com> Date: Thu, 29 Oct 2009 10:33:28 +0100 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <48f46e890910240104o47421525o2cb7013a12696dc3@mail.gmail.com> <48f46e890910250727g6bb5b762oeb8ca94f684b1cca@mail.gmail.com> <4AE8B3B3.7090103@gmail.com> <4AE95BEC.4040102@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [GITGRUB] New menu interface (implementation) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2009 09:33:40 -0000 Bean wrote: > On Thu, Oct 29, 2009 at 5:10 PM, Vladimir 'phcoder' Serbinenko > wrote: > >> Bean wrote: >> >>> On Thu, Oct 29, 2009 at 5:12 AM, Vladimir 'phcoder' Serbinenko >>> wrote: >>> >>> >>>> Bean wrote: >>>> >>>> >>>>> Hi, >>>>> >>>>> Update: >>>>> >>>>> Add timeout, progressbar and savedefault. >>>>> >>>>> savedefault: >>>>> >>>>> Variable savedefault set the system default value. If savedefault=1, >>>>> save the current boot item. >>>>> >>>>> You can also overwrite the default value for individual items, in >>>>> menuentry statement --save option always save this item, and --nosave >>>>> never save the item. If neither --save nor --nosave is specified, the >>>>> system default in savedefault variable is checked. >>>>> >>>>> >>>>> >>>>> >>>> Why do you need this over having a normal save_env? I don't see any >>>> reason to prefer an ad-hoc here over general solution >>>> >>>> >>> Hi, >>> >>> This is more convenient than adding a save_env command to every entry. >>> Users can just set savedefault=1 and all items are saved by default, >>> remove it and it's not saved anymore. They can also config each item >>> individually with --save and --nosave option, which is similar to >>> adding a save_env command at the beginning, but easier to edit. >>> >>> >>> >> It may be more convinient in this case but when you start adding ad-hoc >> structures to any programming languages you end up only clobbering it. >> This is why a simple language C became more widespread than clobbered >> Ada. If you want to execute code on running entries you will need signals >> > > Hi, > > But menuentry statement is already changed for similar reason. Colin > adds --class option, you add --users option, why would add another > option --save and --nosave be any difference ? > > --class is an attribute to control the appearence and --users are to make sure that no part of secured entry is executed > BTW, the save_env method doesn't works menu items generated > dynamically. For example, the menu items added by osdetect.lua or sub > menu items by menu_create. > > Then it's a bug that should be fixed and not swept under the carpet -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git