All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Linux-MIPS <linux-mips@linux-mips.org>,
	"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH -v1] MIPS: a few of fixups and cleanups for the compressed kernel support
Date: Thu, 29 Oct 2009 09:17:22 -0700	[thread overview]
Message-ID: <4AE9C012.5090203@caviumnetworks.com> (raw)
In-Reply-To: <1256797212-7794-1-git-send-email-wuzhangjin@gmail.com>

Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
[...]
>  	.comm .heap,BOOT_HEAP_SIZE,4
>  	.comm .stack,4096*2,4
> +	.set reorder

I feel a little ambivalent about the '.set reorder'.

Since it is at the end of the file, you could omit it.  If you think you 
will add more things around it, you could put a '.set push' at the top 
and then use '.set pop' here.  Or you could leave it as is.

David Daney

  reply	other threads:[~2009-10-29 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29  6:20 [PATCH -v1] MIPS: a few of fixups and cleanups for the compressed kernel support Wu Zhangjin
2009-10-29 16:17 ` David Daney [this message]
2009-10-30  2:16 ` Chih-hung Lu
2009-10-30  2:16   ` Chih-hung Lu
2009-10-30  2:53   ` Wu Zhangjin
2009-11-01  7:43   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE9C012.5090203@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=wuzhangjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.