From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: BUG with Win7 and user-return-notifier
Date: Thu, 29 Oct 2009 18:52:33 +0200 [thread overview]
Message-ID: <4AE9C851.5050708@redhat.com> (raw)
In-Reply-To: <4AE9BF77.8010700@siemens.com>
On 10/29/2009 06:14 PM, Jan Kiszka wrote:
>
> OK, EFER is a globally shared msr. But there still needs to be a
> consensus on the slot id used for guest_msrs and
> shared_msrs_global.msrs, right? move_msr_up works per-vcpu and is
> obviously decoupled...
>
>
move_msr_up() moves a shared_msr_entry, which contains an index into the
shared_msrs_global structure. Double indirection:
msr_index = kvm_shared_msrs_global.msrs[vmx->guest_msrs[index].index].msr
So guest_msrs can be rearranged at will. Except for your oops.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-10-29 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 12:52 BUG with Win7 and user-return-notifier Jan Kiszka
2009-10-27 13:11 ` Avi Kivity
2009-10-27 13:13 ` Jan Kiszka
2009-10-27 13:24 ` Avi Kivity
2009-10-27 13:25 ` Avi Kivity
2009-10-28 8:18 ` Avi Kivity
2009-10-28 14:01 ` Jan Kiszka
2009-10-28 16:00 ` Avi Kivity
2009-10-28 19:55 ` Jan Kiszka
[not found] ` <4AE8AC20.50506@web.de>
2009-10-29 7:37 ` Avi Kivity
2009-10-29 8:03 ` Jan Kiszka
2009-10-29 8:06 ` Jan Kiszka
2009-10-29 8:07 ` Avi Kivity
2009-10-29 8:32 ` Jan Kiszka
2009-10-29 15:45 ` Jan Kiszka
2009-10-29 16:05 ` Avi Kivity
2009-10-29 16:07 ` Jan Kiszka
2009-10-29 16:14 ` Jan Kiszka
2009-10-29 16:52 ` Avi Kivity [this message]
2009-10-29 16:49 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE9C851.5050708@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.