Re: [PATCH] KVM: VMX: Use proper slot index for kvm_set_shared_msr

[Avi Kivity <avi@redhat.com>]

On 10/29/2009 06:53 PM, Jan Kiszka wrote:
> We were missing one indirection here to translate from vmx-local to
> x86 slot indices, and this caused subtle host crashes.
>
>    

Ahh, good catch.  How did it work?

> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> ---
>
> IOW: Win7 boots for me again.
>
>   arch/x86/kvm/vmx.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index a1976c9..6b818c0 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -660,7 +660,8 @@ static void vmx_save_host_state(struct kvm_vcpu *vcpu)
>   	}
>   #endif
>   	for (i = 0; i<  vmx->save_nmsrs; ++i)
> -		kvm_set_shared_msr(i, vmx->guest_msrs[i].data);
> +		kvm_set_shared_msr(vmx->guest_msrs[i].index,
> +				   vmx->guest_msrs[i].data);
>   }
>
>   static void __vmx_load_host_state(struct vcpu_vmx *vmx)
>    


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.