From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, open-osd <osd-dev@open-osd.org>
Subject: Re: [PATCH 4/5] osduld: Use device->release instead of internal kref
Date: Thu, 29 Oct 2009 19:58:49 +0200 [thread overview]
Message-ID: <4AE9D7D9.5010006@panasas.com> (raw)
In-Reply-To: <1256838073.7191.24.camel@mulgrave.site>
On 10/29/2009 07:41 PM, James Bottomley wrote:
>
> Chaining methods like this because of inner knowledge of the
> implementation isn't resilient, it's very fragile.
>
If I would just kfree, because I know the inner code, that would be
fragile.
But overriding a destructor, do what you need, and call previous
distroctor. Does not take any inner knowledge. Just the published fact
that it is a distructor, which will destroy the object.
> Isn't the correct answer to embed your device in struct osd_uld_device?
> They both look to have identical lifetimes and the release rules can
> then handle the dual destruction?
>
See the patch. there I have direct manipulation with inner members.
The chaining is more resilient, i think.
> James
>
>
Boaz
next prev parent reply other threads:[~2009-10-29 17:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 16:51 [PATCHSET 0/5] osd: Revised patches for the 2.6.33 merge window Boaz Harrosh
2009-10-26 16:56 ` [PATCH 1/5] libosd: osd_dev_is_ver1 - Minor API cleanup Boaz Harrosh
2009-10-26 16:57 ` [PATCH 2/5] libosd: osd_sense: OSD_CFO_PERMISSIONS Boaz Harrosh
2009-10-26 16:57 ` [PATCH 3/5] osduld: Ref-counting bug fix Boaz Harrosh
2009-10-26 16:58 ` [PATCH 4/5] osduld: Use device->release instead of internal kref Boaz Harrosh
2009-10-29 17:11 ` James Bottomley
2009-10-29 17:24 ` Boaz Harrosh
2009-10-29 17:41 ` James Bottomley
2009-10-29 17:50 ` Boaz Harrosh
2009-10-29 18:03 ` James Bottomley
2009-10-29 18:10 ` Boaz Harrosh
2009-10-29 18:05 ` Boaz Harrosh
2009-10-29 17:58 ` Boaz Harrosh [this message]
2009-10-29 18:06 ` James Bottomley
2009-11-01 16:43 ` [PATCH 4/5 version 2] " Boaz Harrosh
2009-10-26 16:58 ` [PATCH 5/5] libosd: osd_dev_info: Unique Identification of an OSD device Boaz Harrosh
2009-11-01 16:45 ` [PATCH 5/5 version2] " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE9D7D9.5010006@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.