All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Theodore Tso <tytso@mit.edu>, LKML <linux-kernel@vger.kernel.org>,
	linux-ext4@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org
Subject: Re: [Bug 14354] Re: ext4 increased intolerance to unclean shutdown?
Date: Thu, 29 Oct 2009 16:38:57 -0500	[thread overview]
Message-ID: <4AEA0B71.5050805@redhat.com> (raw)
In-Reply-To: <f7848160910291425q30377641qfe23e74fbc643d89@mail.gmail.com>

Parag Warudkar wrote:
> On Tue, Oct 27, 2009 at 6:15 AM, Aneesh Kumar K.V
> <aneesh.kumar@linux.vnet.ibm.com> wrote:
>> Can you try this patch ?
>>
>> commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65
>> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Date:   Tue Oct 27 15:36:38 2009 +0530
>>
>>    ext4: discard preallocation during truncate
>>
>>    We need to make sure when we drop and reacquire the inode's
>>    i_data_sem we discard the inode preallocation. Otherwise we
>>    could have blocks marked as free in bitmap but still belonging
>>    to prealloc space.
> 
> Just wanted to let you know that I have applied this patch and one
> unclean shutdown later it seems to have not given me any trouble.
> 
> I will continue testing it - hopefully I won't have to reformat  this
> time ( every time I tested previously I ended up having weird issues
> that I decided to get rid of by reformatting /).

I've been running my testcase, and I just hit the usual corruption with 
this patch in place after 8 iterations, I'm afraid.

-Eric

> Parag
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2009-10-29 21:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16  4:28 ext4 increased intolerance to unclean shutdown? Parag Warudkar
2009-10-16  6:31 ` Maxim Levitsky
2009-10-16  9:15 ` [Bug 14354] " Theodore Tso
2009-10-16 13:06   ` Theodore Tso
2009-10-16 19:16   ` Ric Wheeler
2009-10-25  6:22     ` Pavel Machek
2009-10-26 13:49       ` Ric Wheeler
2009-10-16 22:24   ` Parag Warudkar
2009-10-16 22:24     ` Parag Warudkar
2009-10-26 15:42   ` Linus Torvalds
2009-10-27 10:15   ` Aneesh Kumar K.V
2009-10-29 20:10     ` Mingming
2009-10-29 21:25     ` Parag Warudkar
2009-10-29 21:25       ` Parag Warudkar
2009-10-29 21:38       ` Eric Sandeen [this message]
2009-10-30  8:16         ` Theodore Tso
2009-10-30 13:54           ` Eric Sandeen
2009-10-30 13:54             ` Eric Sandeen
2009-10-30 19:56         ` Andreas Dilger
2009-10-31  9:15           ` Theodore Tso
2009-10-31 15:24             ` Aneesh Kumar K.V
2009-10-31 15:24               ` Aneesh Kumar K.V
2009-10-29 21:42       ` Theodore Tso
2009-10-29 21:42         ` Theodore Tso
2009-10-29 21:52         ` Parag Warudkar
2009-10-29 21:52           ` Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AEA0B71.5050805@redhat.com \
    --to=sandeen@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parag.lkml@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.