From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3dEA-0001Ox-8b for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:12:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3dE5-0001Np-Q9 for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:12:17 -0400 Received: from [199.232.76.173] (port=38300 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3dE5-0001Nm-Kt for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:12:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30210) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3dE5-0005dZ-7J for qemu-devel@nongnu.org; Thu, 29 Oct 2009 18:12:13 -0400 Message-ID: <4AEA133A.8010906@redhat.com> Date: Thu, 29 Oct 2009 23:12:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1256841750-15228-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC 0/7] QError v1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, hollisb@us.ibm.com, kraxel@redhat.com > A last note: this series is on top of the (to be merged) QJSon module, > that's why it's a RFC and.. I didn't test it too much. :) I have just two comments: 1) you do > - qemu_error("Device \"%s\" not found. Try -device '?' for a list.\n", > - driver); > + qemu_error_structed(QERR_DEV_NFOUND, "{ 'name': %s }", driver); why not store the "{ 'name': %s }" in the qerror_table? I guess you plan to have different fields in some cases? 2) as I understood it, the consensus was to store the expanded error message (i.e. qerror_print) in the JSON output as well. That would involve returning a QString from qerror_print, I guess. Paolo