From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH][RFC] pv-ops: fix shared irq device passthrough Date: Thu, 29 Oct 2009 15:56:02 -0700 Message-ID: <4AEA1D82.8060609@goop.org> References: <715D42877B251141A38726ABF5CABF2C05509A75F3@pdsmsx503.ccr.corp.intel.com> <4AE60646.7050307@goop.org> <715D42877B251141A38726ABF5CABF2C05509A7C3A@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <715D42877B251141A38726ABF5CABF2C05509A7C3A@pdsmsx503.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Han, Weidong" Cc: "'xen-devel@lists.xensource.com'" , "'keir.fraser@eu.citrix.com'" List-Id: xen-devel@lists.xenproject.org On 10/26/09 18:32, Han, Weidong wrote: >> Hm, not sure about this. The logic in __setup_irq already looks >> pretty tortured, and I'd like to avoid touching it unless there's >> definitively a bug in there. >> >> I think the right question is whether probe_irq() is really doing the >> right test, and whether it could do something else instead? >> > Totally agree. The better way is to change probe_irq, therefore needn't touch kernel irq stuffs. probe_irq is just check if desc->action == NULL or not. The code is there for a long long time (from c/s 26 in linux-2.6.18-xen.hg). I don't know whether it can be replaced. > Could you look into it? How many drivers do interrupt probing these days anyway? I think we can safely not support ISA devices. J