From: Greg Ungerer <gerg@snapgear.com>
To: Tim Abbott <tabbott@ksplice.com>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v4 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE in the linker script.
Date: Fri, 30 Oct 2009 15:02:10 +1000 [thread overview]
Message-ID: <4AEA7352.4050202@snapgear.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0910292118390.24830@dr-wily.mit.edu>
Hi Tim,
Tim Abbott wrote:
> On Fri, 30 Oct 2009, Greg Ungerer wrote:
>
>> Hi Tim,
>>
>> This one gives me:
>>
>> arch/m68knommu/kernel/vmlinux.lds.S:19:1: warning: "BSS" redefined
>> In file included from arch/m68knommu/kernel/vmlinux.lds.S:10:
>> include/asm-generic/vmlinux.lds.h:495:1: warning: this is the location of the
>> previous definition
>>
>> A define named "BSS" is already used inside of vmlinux.lds.S.
>> No big deal, I just changed that internal one.
>>
>> But otherwise no problems with this patch.
>
> This actually wasn't introduced by this patch -- it was introduced when
> the BSS macro was merged into include/asm-generic/vmlinux.lds.h in commit
> ef53dae8658cf0e93d380983824a661067948d87.
>
> Regardless, changing the internal one was the right fix.
Indeed. Yep. I'll commit a fix for this first.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2009-10-30 5:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 16:56 [PATCH v2 0/2] Linker script cleanup patches for m68knommu Tim Abbott
2009-09-22 16:56 ` [PATCH v2 1/2] m68knommu: Make THREAD_SIZE available to assembly files Tim Abbott
2009-09-22 16:56 ` [PATCH v2 2/2] m68knommu: Clean up linker script using new linker script macros Tim Abbott
2009-10-01 5:56 ` Greg Ungerer
2009-10-12 14:47 ` Tim Abbott
2009-10-12 23:46 ` Greg Ungerer
2009-10-13 1:30 ` [PATCH v3 0/7] " Tim Abbott
2009-10-13 1:30 ` [PATCH v3 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE in the linker script Tim Abbott
2009-10-13 1:30 ` [PATCH v3 2/7] m68knommu: Make THREAD_SIZE available to assembly files Tim Abbott
2009-10-13 1:30 ` [PATCH v3 3/7] m68knommu: Use INIT_TASK_DATA and CACHELINE_ALIGNED_DATA Tim Abbott
2009-10-13 1:30 ` [PATCH v3 4/7] m68knommu: Use more macros inside the .init section Tim Abbott
2009-10-13 1:30 ` [PATCH v3 5/7] m68knommu: Move __init_begin out of " Tim Abbott
2009-10-13 1:30 ` [PATCH v3 6/7] m68knommu: Move __init_end " Tim Abbott
2009-10-13 1:30 ` [PATCH v3 7/7] m68knommu: Split the .init section into INIT_TEXT_SECTION and INIT_DATA_SECTION Tim Abbott
2009-10-14 4:41 ` [PATCH v3 6/7] m68knommu: Move __init_end out of the .init section Greg Ungerer
2009-10-14 15:16 ` Sam Ravnborg
2009-10-18 17:22 ` Tim Abbott
2009-10-18 17:23 ` [PATCH v4 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE in the linker script Tim Abbott
2009-10-30 0:57 ` Greg Ungerer
2009-10-30 1:22 ` Tim Abbott
2009-10-30 5:02 ` Greg Ungerer [this message]
2009-10-18 17:23 ` [PATCH v4 2/7] m68knommu: Make THREAD_SIZE available to assembly files Tim Abbott
2009-10-18 17:23 ` [PATCH v4 3/7] m68knommu: Use INIT_TASK_DATA and CACHELINE_ALIGNED_DATA Tim Abbott
2009-10-18 17:23 ` [PATCH v4 4/7] m68knommu: Use more macros inside the .init section Tim Abbott
2009-10-18 17:23 ` [PATCH v4 5/7] m68knommu: Move __init_begin out of " Tim Abbott
2009-10-18 17:23 ` [PATCH v4 6/7] m68knommu: Move __init_end " Tim Abbott
2009-10-18 17:23 ` [PATCH v4 7/7] m68knommu: Split the .init section into INIT_TEXT_SECTION and INIT_DATA_SECTION Tim Abbott
2009-10-30 1:13 ` Greg Ungerer
2009-10-30 1:30 ` Tim Abbott
2009-10-30 5:10 ` Greg Ungerer
2009-10-30 11:35 ` Sam Ravnborg
2009-10-30 18:10 ` Tim Abbott
2009-10-30 0:44 ` [PATCH v3 6/7] m68knommu: Move __init_end out of the .init section Greg Ungerer
2009-10-13 5:55 ` [PATCH v3 4/7] m68knommu: Use more macros inside " Greg Ungerer
2009-10-13 15:39 ` Tim Abbott
2009-10-14 4:22 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEA7352.4050202@snapgear.com \
--to=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.