All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/6] vlan: Optimize multiple unregistration
Date: Fri, 30 Oct 2009 07:30:43 +0100	[thread overview]
Message-ID: <4AEA8813.9090505@gmail.com> (raw)
In-Reply-To: <4AE9D000.90603@trash.net>

Patrick McHardy a écrit :
> Eric Dumazet wrote:
>> Patrick McHardy a écrit :
>>
>>> Indeed, but unregister_vlan_dev() destroys the group once the
>>> count has reached zero, so we must not access it after that.
>> Well, I hoped call_rcu() callback doesnt fire and kfree(grp) until we exited
>> from unregister_vlan_dev_alls(), with RTNL locked...
> 
> The RTNL is a mutex, so it shouldn't prevent call_rcu from firing.

Oops this is totally right of course, so your patch is actually a bug fix :)

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>


  reply	other threads:[~2009-10-30  6:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27 17:06 [PATCH 4/6] vlan: Optimize multiple unregistration Eric Dumazet
2009-10-28 20:05 ` Patrick McHardy
2009-10-28 20:47   ` Eric Dumazet
2009-10-29 13:45     ` Patrick McHardy
2009-10-29 14:23       ` Patrick McHardy
2009-10-29 14:30         ` Eric Dumazet
2009-10-29 14:33           ` Patrick McHardy
2009-10-29 14:43             ` Eric Dumazet
2009-10-29 17:25               ` Patrick McHardy
2009-10-30  6:30                 ` Eric Dumazet [this message]
2009-10-30  6:43                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AEA8813.9090505@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.