From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N3uEZ-0005Ig-NM
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:21:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N3uEV-0005Gj-UQ
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:21:51 -0400
Received: from [199.232.76.173] (port=34945 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N3uEV-0005GY-Mv
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:21:47 -0400
Received: from mail-ew0-f221.google.com ([209.85.219.221]:60934)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1N3uEV-0005ND-4R
	for qemu-devel@nongnu.org; Fri, 30 Oct 2009 12:21:47 -0400
Received: by ewy21 with SMTP id 21so3033588ewy.8
	for <qemu-devel@nongnu.org>; Fri, 30 Oct 2009 09:21:46 -0700 (PDT)
Message-ID: <4AEB1294.6000204@codemonkey.ws>
Date: Fri, 30 Oct 2009 11:21:40 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()
References: <1256667399-3149-1-git-send-email-markmc@redhat.com>
	<1256667399-3149-6-git-send-email-markmc@redhat.com>
In-Reply-To: <1256667399-3149-6-git-send-email-markmc@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Scott Tsai <scottt.tw@gmail.com>, Sven Rudolph <Sven_Rudolph@drewag.de>, qemu-devel@nongnu.org

Mark McLoughlin wrote:
> Okay, let's try re-enabling the drain-entire-queue behaviour, with a
> difference - before each subsequent packet, use qemu_can_send_packet()
> to check that we can send it. This is similar to how we check before
> polling the tap fd and avoids having to drop a packet if the receiver
> cannot handle it.
>
> This patch should be a performance improvement since we no longer have
> to go through the mainloop for each packet.
>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
>   

Could you rebase and rend this patch against master?  I've got 1-4 in 
staging.

The GSO changes make resolving this non trivial (for me at least :-)).

Regards,

Anthony Liguori