From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N40aq-0007yc-0x for mharc-grub-devel@gnu.org; Fri, 30 Oct 2009 19:09:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N40ao-0007yK-2l for grub-devel@gnu.org; Fri, 30 Oct 2009 19:09:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N40ai-0007wQ-Jv for grub-devel@gnu.org; Fri, 30 Oct 2009 19:09:12 -0400 Received: from [199.232.76.173] (port=59998 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N40ai-0007wG-GU for grub-devel@gnu.org; Fri, 30 Oct 2009 19:09:08 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:64107) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N40ai-0006yM-4n for grub-devel@gnu.org; Fri, 30 Oct 2009 19:09:08 -0400 Received: by ewy7 with SMTP id 7so1452323ewy.31 for ; Fri, 30 Oct 2009 16:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=SLVfTQ4+WLhZNUSIhvMPqvnqzzuvYakQUpY0k6LTE1k=; b=fAhMioSKxvb1uHy30eGVEO28oFoCo+JqIQD6xhIsFTEZtns5MkQO5GrAmeyWKRib1t 2kTVuycq5LVLYTCp3U7dkew5h3EPq6/N2A53IxnIpYG2l6Bb6K9FqPsIQOeXuFW8V3cD qNN1gYmuAtBrMNPU8N9J1DMpw41L8QKeg8G3A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=wvSpTVl1HJjlIqaB0YQp7teotvgukZf469YtJ+md+OdRy+pLKHPi44mFlmPbSiGWDy NElBrh4wEApYu97pOTv5bzDQYet5mSF2TkypL1aYpWd6WaXTCUICTJ1BlL+Ut+LRRFc1 FjL6LpNVkeSHTOvA25D2ruKnBJ7rShlu2P1yI= Received: by 10.216.90.18 with SMTP id d18mr848013wef.225.1256944147196; Fri, 30 Oct 2009 16:09:07 -0700 (PDT) Received: from debian.bg45.phnet (65.Red-88-21-98.staticIP.rima-tde.net [88.21.98.65]) by mx.google.com with ESMTPS id 10sm9775042eyz.35.2009.10.30.16.09.05 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 30 Oct 2009 16:09:06 -0700 (PDT) Message-ID: <4AEB7207.9060009@gmail.com> Date: Sat, 31 Oct 2009 00:08:55 +0100 From: Vladimir 'phcoder' Serbinenko User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: The development of GRUB 2 References: <20091026181010.GA22942@thorin> In-Reply-To: <20091026181010.GA22942@thorin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] turn grub-emu into a port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2009 23:09:14 -0000 Robert Millan wrote: > This turns grub-emu into a port in order to make it easier to port GRUB to > new CPUs. A porter can then do the CPU port without having to worry about > firmware and/or hardware drivers initially. > > Patch attached. Branch is available in > bzr+ssh://bzr.savannah.gnu.org/grub/people/robertmh/grub-emu/ > > Following hunk is a regression for me: - return (tv.tv_sec * GRUB_TICKS_PER_SECOND - + (((tv.tv_sec % GRUB_TICKS_PER_SECOND) * 1000000 + tv.tv_usec) - * GRUB_TICKS_PER_SECOND / 1000000)); + GRUB_COMPILE_TIME_ASSERT (GRUB_TICKS_PER_SECOND == 1000000); + return (tv.tv_sec * 1000000 + tv.tv_usec); Having virtual clock going at any rate is an advantage for debugging. Other than this I'm ok with this patch and you can merge it into experimental > ------------------------------------------------------------------------ > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git