All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Németh Márton" <nm127@freemail.hu>
To: Jean-Francois Moine <moinejf@free.fr>,
	Hans de Goede <hdegoede@redhat.com>,
	V4L Mailing List <linux-media@vger.kernel.org>
Cc: Thomas Kaiser <thomas@kaiser-linux.li>,
	Theodore Kilgore <kilgota@auburn.edu>,
	Kyle Guinn <elyk03@gmail.com>
Subject: [PATCH 01/21] gspca pac7302/pac7311: add prefix for sensor specific functions
Date: Sun, 01 Nov 2009 00:13:24 +0100	[thread overview]
Message-ID: <4AECC494.7050402@freemail.hu> (raw)

From: Márton Németh <nm127@freemail.hu>

There are some functions which are already sensor specific. Mark them
with pac7302_ or pac7311_ prefix

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Thomas Kaiser <thomas@kaiser-linux.li>
Cc: Theodore Kilgore <kilgota@auburn.edu>
Cc: Kyle Guinn <elyk03@gmail.com>
---
diff -uprN a/drivers/media/video/gspca/pac7311.c b/drivers/media/video/gspca/pac7311.c
--- a/drivers/media/video/gspca/pac7311.c	2009-10-30 16:12:05.000000000 +0100
+++ b/drivers/media/video/gspca/pac7311.c	2009-10-30 17:09:52.000000000 +0100
@@ -543,7 +543,7 @@ static int sd_config(struct gspca_dev *g
 }

 /* This function is used by pac7302 only */
-static void setbrightcont(struct gspca_dev *gspca_dev)
+static void pac7302_setbrightcont(struct gspca_dev *gspca_dev)
 {
 	struct sd *sd = (struct sd *) gspca_dev;
 	int i, v;
@@ -570,7 +570,7 @@ static void setbrightcont(struct gspca_d
 }

 /* This function is used by pac7311 only */
-static void setcontrast(struct gspca_dev *gspca_dev)
+static void pac7311_setcontrast(struct gspca_dev *gspca_dev)
 {
 	struct sd *sd = (struct sd *) gspca_dev;

@@ -581,7 +581,7 @@ static void setcontrast(struct gspca_dev
 }

 /* This function is used by pac7302 only */
-static void setcolors(struct gspca_dev *gspca_dev)
+static void pac7302_setcolors(struct gspca_dev *gspca_dev)
 {
 	struct sd *sd = (struct sd *) gspca_dev;
 	int i, v;
@@ -700,11 +700,11 @@ static int sd_start(struct gspca_dev *gs

 	if (sd->sensor == SENSOR_PAC7302) {
 		reg_w_var(gspca_dev, start_7302);
-		setbrightcont(gspca_dev);
-		setcolors(gspca_dev);
+		pac7302_setbrightcont(gspca_dev);
+		pac7302_setcolors(gspca_dev);
 	} else {
 		reg_w_var(gspca_dev, start_7311);
-		setcontrast(gspca_dev);
+		pac7311_setcontrast(gspca_dev);
 	}
 	setgain(gspca_dev);
 	setexposure(gspca_dev);
@@ -923,7 +923,7 @@ static int sd_setbrightness(struct gspca

 	sd->brightness = val;
 	if (gspca_dev->streaming)
-		setbrightcont(gspca_dev);
+		pac7302_setbrightcont(gspca_dev);
 	return 0;
 }

@@ -942,9 +942,9 @@ static int sd_setcontrast(struct gspca_d
 	sd->contrast = val;
 	if (gspca_dev->streaming) {
 		if (sd->sensor == SENSOR_PAC7302)
-			setbrightcont(gspca_dev);
+			pac7302_setbrightcont(gspca_dev);
 		else
-			setcontrast(gspca_dev);
+			pac7311_setcontrast(gspca_dev);
 	}
 	return 0;
 }
@@ -963,7 +963,7 @@ static int sd_setcolors(struct gspca_dev

 	sd->colors = val;
 	if (gspca_dev->streaming)
-		setcolors(gspca_dev);
+		pac7302_setcolors(gspca_dev);
 	return 0;
 }


                 reply	other threads:[~2009-10-31 23:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AECC494.7050402@freemail.hu \
    --to=nm127@freemail.hu \
    --cc=elyk03@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=kilgota@auburn.edu \
    --cc=linux-media@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=thomas@kaiser-linux.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.