All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add I2C multibus support for OMAP2/3 boards
Date: Sun, 01 Nov 2009 11:09:25 -0600	[thread overview]
Message-ID: <4AEDC0C5.2040905@windriver.com> (raw)
In-Reply-To: <4AED8256.1090208@windriver.com>

Tom wrote:
> Dirk Behme wrote:
>> Tom Rix wrote:
>>> From: Syed Mohammed Khasim <khasim@ti.com>
>>>
>>> This was cherry-picked from
>>>
>>> repo: http://www.beagleboard.org/u-boot-arm.git
>>> commit: 52eddcd07c2e7ad61d15bab2cf2d0d21466eaca2
>>>
>>> In addition to adding multibus support, this patch
>>> also cleans up the register access.  The register
>>> access has been changed from #defines to a structure.
>> Have you looked at my proposal I sent some hours before your patch?
> 
> Sorry.  I did not.
> Not surprisingly it looks similar.
> 
> The formatting changes you mentioned were part of the original
> cherry-picked commit.  I tried to leave as much of the original
> commit intact as possible.  I ran but ignored the output of
> checkpatch.. The biggest complaint it has is with 80 char lines.
> 
> I looked over your patch.
> It looks like an improvement to mine.
> 
> I'm all for dropping mine and using yours.
> I will run test yours.
> 
> Do you have a zippy board that you can use to test the 2nd bus ?
> 
Dirk,

Some feedback.

No regressions on MAKEALL arm

I ran tested your patch Zoom1 and Beagle.
Default i2c looks good.
I did not test the multibus support.

Looks good, please officially submit your patch.

Tom

> Tom
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2009-11-01 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01  1:52 [U-Boot] Better I2C support for OMAP Tom Rix
2009-11-01  1:52 ` [U-Boot] [PATCH] Add I2C multibus support for OMAP2/3 boards Tom Rix
2009-11-01  8:24   ` Dirk Behme
2009-11-01 12:43     ` Tom
2009-11-01 17:09       ` Tom [this message]
2009-11-02  7:28     ` Heiko Schocher
2009-11-02 19:32       ` Dirk Behme
2009-11-05  6:25         ` Heiko Schocher
2009-11-05  6:35           ` Dirk Behme
2009-11-05  6:50             ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AEDC0C5.2040905@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.