From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: Check if unplug handler exists before calling it
Date: Mon, 02 Nov 2009 10:18:56 +0100 [thread overview]
Message-ID: <4AEEA400.40001@redhat.com> (raw)
In-Reply-To: <1257143276-9428-1-git-send-email-amit.shah@redhat.com>
On 11/02/09 07:27, Amit Shah wrote:
> A bus may have hotplugging enabled but not have the 'unplug'
> callback defined, which would lead to a crash on trying to
> unplug a device on the bus.
Which would be a clear bug in the bus implementation.
> + if (!dev->info->unplug) {
assert(dev->info->unplug != NULL) ?
cheers,
Gerd
next prev parent reply other threads:[~2009-11-02 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 6:27 [Qemu-devel] [PATCH] qdev: Check if unplug handler exists before calling it Amit Shah
2009-11-02 9:18 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-02 9:26 Amit Shah
2009-11-02 9:58 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEEA400.40001@redhat.com \
--to=kraxel@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.